Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-10 Thread Lina Iyer
On Fri, Aug 10 2018 at 09:06 -0600, Stephen Boyd wrote: Quoting Marc Zyngier (2018-08-10 00:45:12) On Thu, 09 Aug 2018 18:30:53 +0100, Stephen Boyd wrote: > > Quoting Marc Zyngier (2018-08-07 23:26:32) > > > > Level interrupts should be taken care of without doing anything, by the > > very

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-10 Thread Lina Iyer
On Fri, Aug 10 2018 at 09:06 -0600, Stephen Boyd wrote: Quoting Marc Zyngier (2018-08-10 00:45:12) On Thu, 09 Aug 2018 18:30:53 +0100, Stephen Boyd wrote: > > Quoting Marc Zyngier (2018-08-07 23:26:32) > > > > Level interrupts should be taken care of without doing anything, by the > > very

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-10 Thread Stephen Boyd
Quoting Marc Zyngier (2018-08-10 00:45:12) > On Thu, 09 Aug 2018 18:30:53 +0100, > Stephen Boyd wrote: > > > > Quoting Marc Zyngier (2018-08-07 23:26:32) > > > > > > Level interrupts should be taken care of without doing anything, by the > > > very nature of being a level signal. > > > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-10 Thread Stephen Boyd
Quoting Marc Zyngier (2018-08-10 00:45:12) > On Thu, 09 Aug 2018 18:30:53 +0100, > Stephen Boyd wrote: > > > > Quoting Marc Zyngier (2018-08-07 23:26:32) > > > > > > Level interrupts should be taken care of without doing anything, by the > > > very nature of being a level signal. > > > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-10 Thread Marc Zyngier
On Thu, 09 Aug 2018 18:30:53 +0100, Stephen Boyd wrote: > > Quoting Marc Zyngier (2018-08-07 23:26:32) > > On Tue, 07 Aug 2018 23:05:07 -0700 > > Stephen Boyd wrote: > > > > > Quoting Lina Iyer (2018-08-02 05:58:27) > > > > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > > > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-10 Thread Marc Zyngier
On Thu, 09 Aug 2018 18:30:53 +0100, Stephen Boyd wrote: > > Quoting Marc Zyngier (2018-08-07 23:26:32) > > On Tue, 07 Aug 2018 23:05:07 -0700 > > Stephen Boyd wrote: > > > > > Quoting Lina Iyer (2018-08-02 05:58:27) > > > > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > > > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-09 Thread Stephen Boyd
Quoting Marc Zyngier (2018-08-07 23:26:32) > On Tue, 07 Aug 2018 23:05:07 -0700 > Stephen Boyd wrote: > > > Quoting Lina Iyer (2018-08-02 05:58:27) > > > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > > > > > >Sure. But once woken up (GIC *and* TLMM), the gpio line (which I > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-09 Thread Stephen Boyd
Quoting Marc Zyngier (2018-08-07 23:26:32) > On Tue, 07 Aug 2018 23:05:07 -0700 > Stephen Boyd wrote: > > > Quoting Lina Iyer (2018-08-02 05:58:27) > > > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > > > > > >Sure. But once woken up (GIC *and* TLMM), the gpio line (which I > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-08 Thread Marc Zyngier
On Tue, 07 Aug 2018 23:05:07 -0700 Stephen Boyd wrote: > Quoting Lina Iyer (2018-08-02 05:58:27) > > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > > > >Sure. But once woken up (GIC *and* TLMM), the gpio line (which I > > >assume is level) is still high at the TLMM input. So why

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-08 Thread Marc Zyngier
On Tue, 07 Aug 2018 23:05:07 -0700 Stephen Boyd wrote: > Quoting Lina Iyer (2018-08-02 05:58:27) > > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > > > >Sure. But once woken up (GIC *and* TLMM), the gpio line (which I > > >assume is level) is still high at the TLMM input. So why

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-08 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-02 05:58:27) > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > >Sure. But once woken up (GIC *and* TLMM), the gpio line (which I > >assume is level) is still high at the TLMM input. So why isn't it > >registering that state once it has been woken up? > > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-08 Thread Stephen Boyd
Quoting Lina Iyer (2018-08-02 05:58:27) > On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: > > > >Sure. But once woken up (GIC *and* TLMM), the gpio line (which I > >assume is level) is still high at the TLMM input. So why isn't it > >registering that state once it has been woken up? > > >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Lina Iyer
On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: On Thu, 02 Aug 2018 07:51:04 +0100, Lina Iyer wrote: On Thu, Aug 02 2018 at 00:08 -0600, Marc Zyngier wrote: > Hi Lina, > > On Wed, 01 Aug 2018 20:45:38 +0100, > Lina Iyer wrote: >> >> Thanks for the feedback, Marc. >> >> On Wed, Aug 01

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Lina Iyer
On Thu, Aug 02 2018 at 01:27 -0600, Marc Zyngier wrote: On Thu, 02 Aug 2018 07:51:04 +0100, Lina Iyer wrote: On Thu, Aug 02 2018 at 00:08 -0600, Marc Zyngier wrote: > Hi Lina, > > On Wed, 01 Aug 2018 20:45:38 +0100, > Lina Iyer wrote: >> >> Thanks for the feedback, Marc. >> >> On Wed, Aug 01

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Marc Zyngier
On Thu, 02 Aug 2018 07:51:04 +0100, Lina Iyer wrote: > > On Thu, Aug 02 2018 at 00:08 -0600, Marc Zyngier wrote: > > Hi Lina, > > > > On Wed, 01 Aug 2018 20:45:38 +0100, > > Lina Iyer wrote: > >> > >> Thanks for the feedback, Marc. > >> > >> On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Marc Zyngier
On Thu, 02 Aug 2018 07:51:04 +0100, Lina Iyer wrote: > > On Thu, Aug 02 2018 at 00:08 -0600, Marc Zyngier wrote: > > Hi Lina, > > > > On Wed, 01 Aug 2018 20:45:38 +0100, > > Lina Iyer wrote: > >> > >> Thanks for the feedback, Marc. > >> > >> On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Lina Iyer
On Thu, Aug 02 2018 at 00:08 -0600, Marc Zyngier wrote: Hi Lina, On Wed, 01 Aug 2018 20:45:38 +0100, Lina Iyer wrote: Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > On Wed, 01 Aug 2018 03:00:18 +0100, > Lina Iyer wrote: >> >> +static irqreturn_t

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Lina Iyer
On Thu, Aug 02 2018 at 00:08 -0600, Marc Zyngier wrote: Hi Lina, On Wed, 01 Aug 2018 20:45:38 +0100, Lina Iyer wrote: Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > On Wed, 01 Aug 2018 03:00:18 +0100, > Lina Iyer wrote: >> >> +static irqreturn_t

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Marc Zyngier
Hi Lina, On Wed, 01 Aug 2018 20:45:38 +0100, Lina Iyer wrote: > > Thanks for the feedback, Marc. > > On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > > On Wed, 01 Aug 2018 03:00:18 +0100, > > Lina Iyer wrote: > >> > >> +static irqreturn_t wake_irq_gpio_handler(int irq, void *data) >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-02 Thread Marc Zyngier
Hi Lina, On Wed, 01 Aug 2018 20:45:38 +0100, Lina Iyer wrote: > > Thanks for the feedback, Marc. > > On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > > On Wed, 01 Aug 2018 03:00:18 +0100, > > Lina Iyer wrote: > >> > >> +static irqreturn_t wake_irq_gpio_handler(int irq, void *data) >

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Lina Iyer
On Wed, Aug 01 2018 at 16:38 -0600, Bjorn Andersson wrote: On Wed 01 Aug 12:45 PDT 2018, Lina Iyer wrote: Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > On Wed, 01 Aug 2018 03:00:18 +0100, > Lina Iyer wrote: [..] > Why isn't that the case? And if

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Lina Iyer
On Wed, Aug 01 2018 at 16:38 -0600, Bjorn Andersson wrote: On Wed 01 Aug 12:45 PDT 2018, Lina Iyer wrote: Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > On Wed, 01 Aug 2018 03:00:18 +0100, > Lina Iyer wrote: [..] > Why isn't that the case? And if

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Bjorn Andersson
On Wed 01 Aug 12:45 PDT 2018, Lina Iyer wrote: > Thanks for the feedback, Marc. > > On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > > On Wed, 01 Aug 2018 03:00:18 +0100, > > Lina Iyer wrote: [..] > > Why isn't that the case? And if that's because the HW is broken and > > doesn't

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Bjorn Andersson
On Wed 01 Aug 12:45 PDT 2018, Lina Iyer wrote: > Thanks for the feedback, Marc. > > On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: > > On Wed, 01 Aug 2018 03:00:18 +0100, > > Lina Iyer wrote: [..] > > Why isn't that the case? And if that's because the HW is broken and > > doesn't

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Lina Iyer
Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: On Wed, 01 Aug 2018 03:00:18 +0100, Lina Iyer wrote: +static irqreturn_t wake_irq_gpio_handler(int irq, void *data) +{ + struct irq_data *irqd = data; + struct irq_desc *desc =

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Lina Iyer
Thanks for the feedback, Marc. On Wed, Aug 01 2018 at 00:31 -0600, Marc Zyngier wrote: On Wed, 01 Aug 2018 03:00:18 +0100, Lina Iyer wrote: +static irqreturn_t wake_irq_gpio_handler(int irq, void *data) +{ + struct irq_data *irqd = data; + struct irq_desc *desc =

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Marc Zyngier
On Wed, 01 Aug 2018 03:00:18 +0100, Lina Iyer wrote: > > QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on > domain can wakeup the SoC, when interrupts and GPIOs are routed to the > its interrupt controller. Select GPIOs that are deemed wakeup capable are > routed to

Re: [PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-08-01 Thread Marc Zyngier
On Wed, 01 Aug 2018 03:00:18 +0100, Lina Iyer wrote: > > QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on > domain can wakeup the SoC, when interrupts and GPIOs are routed to the > its interrupt controller. Select GPIOs that are deemed wakeup capable are > routed to

[PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-07-31 Thread Lina Iyer
QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on domain can wakeup the SoC, when interrupts and GPIOs are routed to the its interrupt controller. Select GPIOs that are deemed wakeup capable are routed to specific PDC pins. The PDC wakes up the GIC and replays the interrupt

[PATCH RESEND RFC 1/4] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-07-31 Thread Lina Iyer
QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on domain can wakeup the SoC, when interrupts and GPIOs are routed to the its interrupt controller. Select GPIOs that are deemed wakeup capable are routed to specific PDC pins. The PDC wakes up the GIC and replays the interrupt