Re: [PATCH RESEND2] lib: fix bitmap_parse() on 64-bit big endian archs

2020-06-08 Thread Andy Shevchenko
On Mon, Jun 08, 2020 at 02:44:34PM +0200, Alexander Gordeev wrote: > On Mon, Jun 08, 2020 at 03:03:05PM +0300, Andy Shevchenko wrote: > > On Mon, Jun 8, 2020 at 1:26 PM Alexander Gordeev > > wrote: > > > > > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does not > > > take into account

Re: [PATCH RESEND2] lib: fix bitmap_parse() on 64-bit big endian archs

2020-06-08 Thread Alexander Gordeev
On Mon, Jun 08, 2020 at 03:03:05PM +0300, Andy Shevchenko wrote: > On Mon, Jun 8, 2020 at 1:26 PM Alexander Gordeev > wrote: > > > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does not > > take into account order of halfwords on 64-bit big endian > > architectures. As result (at least)

Re: [PATCH RESEND2] lib: fix bitmap_parse() on 64-bit big endian archs

2020-06-08 Thread Andy Shevchenko
On Mon, Jun 8, 2020 at 3:03 PM Andy Shevchenko wrote: > On Mon, Jun 8, 2020 at 1:26 PM Alexander Gordeev > wrote: ... > Can't we simple do > > int chunk_index = 0; > ... > do { > #if defined(CONFIG_64BIT) && defined(__BIG_ENDIAN) >end =

Re: [PATCH RESEND2] lib: fix bitmap_parse() on 64-bit big endian archs

2020-06-08 Thread Andy Shevchenko
On Mon, Jun 8, 2020 at 1:26 PM Alexander Gordeev wrote: > > Commit 2d6261583be0 ("lib: rework bitmap_parse()") does not > take into account order of halfwords on 64-bit big endian > architectures. As result (at least) Receive Packet Steering, > IRQ affinity masks and runtime kernel test

[PATCH RESEND2] lib: fix bitmap_parse() on 64-bit big endian archs

2020-06-08 Thread Alexander Gordeev
Commit 2d6261583be0 ("lib: rework bitmap_parse()") does not take into account order of halfwords on 64-bit big endian architectures. As result (at least) Receive Packet Steering, IRQ affinity masks and runtime kernel test "test_bitmap" get broken on s390. Fixes: 2d6261583be0 ("lib: rework