Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-19 Thread Michael Kerrisk (man-pages)
On 19 December 2017 at 18:52, Keno Fischer wrote: > Yes it seems like an EINTR return should be considered a bug, so please drop > this from your patch queue. Thanks for the follow up. Okay -- thanks for the info. Cheers, Michael > On Dec 19, 2017 14:57, "Michael Kerrisk (man-pages)" > wrote

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-19 Thread Michael Kerrisk (man-pages)
Hi Keno, On 12/04/2017 10:03 PM, Keno Fischer wrote: > Hi Michael, > > I was hoping to get a clear statement one way or another from the kernel > maintainers as to whether an EINTR from stat() is supposed to be allowed > kernel behavior (hence the RFC in the subject). If it's not, then I don't

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-04 Thread Matthew Wilcox
On Sat, Dec 02, 2017 at 10:15:33PM -0500, Keno Fischer wrote: > This is exactly the discussion I want to generate, so thank you. > I should point out that I'm not advocating for anything other > than clarity of what kernel behavior user space may assume. I don't think we tend to document short-liv

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-04 Thread Keno Fischer
Hi Michael, I was hoping to get a clear statement one way or another from the kernel maintainers as to whether an EINTR from stat() is supposed to be allowed kernel behavior (hence the RFC in the subject). If it's not, then I don't think it should be documented, even if there is buggy filesystems

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-04 Thread Michael Kerrisk (man-pages)
Hello Keno On 12/03/2017 04:15 AM, Keno Fischer wrote: > Resending as plain text (apologies for those receiving it twice, and > those that got > an HTML copy, I'm used to my mail client switching that over > automatically, which > for some reason didn't happen here). > > > This is exactly the di

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-03 Thread walter harms
Am 03.12.2017 01:23, schrieb Keno Fischer: > Particularly on network file systems, a stat call may require > submitting a message over the network and waiting interruptably > for a reply. > > Signed-off-by: Keno Fischer > --- > > The catalyst for this patch was me experiencing EINTR errors whe

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-02 Thread Keno Fischer
Resending as plain text (apologies for those receiving it twice, and those that got an HTML copy, I'm used to my mail client switching that over automatically, which for some reason didn't happen here). This is exactly the discussion I want to generate, so thank you. I should point out that I'm n

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-02 Thread Matthew Wilcox
On Sat, Dec 02, 2017 at 07:23:59PM -0500, Keno Fischer wrote: > The catalyst for this patch was me experiencing EINTR errors when > using the 9p file system. In linux commit 9523feac, the 9p file > system was changed to use wait_event_killable instead of > wait_event_interruptible, which does indee

[PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-02 Thread Keno Fischer
Particularly on network file systems, a stat call may require submitting a message over the network and waiting interruptably for a reply. Signed-off-by: Keno Fischer --- The catalyst for this patch was me experiencing EINTR errors when using the 9p file system. In linux commit 9523feac, the 9p