Re: [PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-08 Thread Hector Palacios
On 04/08/2013 10:16 AM, Guenter Roeck wrote: On Mon, Apr 08, 2013 at 09:48:57AM +0200, Hector Palacios wrote: On 04/05/2013 08:34 PM, Guenter Roeck wrote: On Fri, Apr 05, 2013 at 06:09:44PM +0200, Hector Palacios wrote: A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS ioc

Re: [PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2013 at 09:48:57AM +0200, Hector Palacios wrote: > On 04/05/2013 08:34 PM, Guenter Roeck wrote: > >On Fri, Apr 05, 2013 at 06:09:44PM +0200, Hector Palacios wrote: > >>A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS > >>ioctl and flag WDIOS_DISABLECARD. If the

Re: [PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-08 Thread Hector Palacios
On 04/05/2013 08:34 PM, Guenter Roeck wrote: On Fri, Apr 05, 2013 at 06:09:44PM +0200, Hector Palacios wrote: A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS ioctl and flag WDIOS_DISABLECARD. If the device is closed after this operation, watchdog_release() is called and st

Re: [PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-05 Thread Guenter Roeck
On Fri, Apr 05, 2013 at 06:09:44PM +0200, Hector Palacios wrote: > A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS > ioctl and flag WDIOS_DISABLECARD. If the device is closed after this > operation, watchdog_release() is called and status bits checked for > stopping it. Besid

[PATCH RFC] watchdog: core: don't try to stop device if not running

2013-04-05 Thread Hector Palacios
A watchdog device may be stopped from userspace using WDIOC_SETOPTIONS ioctl and flag WDIOS_DISABLECARD. If the device is closed after this operation, watchdog_release() is called and status bits checked for stopping it. Besides, if the device has not been unregistered a critical message "watchdog