Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-12 Thread David Woodhouse
On Tue, 2020-12-01 at 16:40 -0800, Ankur Arora wrote: > > How come we get to pin the page and directly dereference it every time, > > while kvm_setup_pvclock_page() has to use kvm_write_guest_cached() > > instead? > > So looking at my WIP trees from the time, this is something that > we went back

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-04 Thread Sean Christopherson
On Thu, Dec 03, 2020, David Woodhouse wrote: > On Wed, 2020-12-02 at 12:32 -0800, Ankur Arora wrote: > > > On IRC, Paolo told me that permanent pinning causes problems for memory > > > hotplug, and pointed me at the trick we do with an MMU notifier and > > > kvm_vcpu_reload_apic_access_page(). > >

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-03 Thread David Woodhouse
On Wed, 2020-12-02 at 12:32 -0800, Ankur Arora wrote: > > On IRC, Paolo told me that permanent pinning causes problems for memory > > hotplug, and pointed me at the trick we do with an MMU notifier and > > kvm_vcpu_reload_apic_access_page(). > > Okay that answers my question. Thanks for clearing

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-02 Thread Ankur Arora
On 2020-12-02 2:44 a.m., Joao Martins wrote: [late response - was on holiday yesterday] On 12/2/20 12:40 AM, Ankur Arora wrote: On 2020-12-01 5:07 a.m., David Woodhouse wrote: On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote: +static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-02 Thread Ankur Arora
On 2020-12-02 4:20 a.m., David Woodhouse wrote: On Wed, 2020-12-02 at 10:44 +, Joao Martins wrote: [late response - was on holiday yesterday] On 12/2/20 12:40 AM, Ankur Arora wrote: On 2020-12-01 5:07 a.m., David Woodhouse wrote: On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote:

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-02 Thread David Woodhouse
On Wed, 2020-12-02 at 10:44 +, Joao Martins wrote: > [late response - was on holiday yesterday] > > On 12/2/20 12:40 AM, Ankur Arora wrote: > > On 2020-12-01 5:07 a.m., David Woodhouse wrote: > > > On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote: > > > > +static int

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-02 Thread Joao Martins
On 12/2/20 5:17 AM, Ankur Arora wrote: > On 2020-12-01 5:26 p.m., David Woodhouse wrote >> On Tue, 2020-12-01 at 16:40 -0800, Ankur Arora wrote: >>> On 2020-12-01 5:07 a.m., David Woodhouse wrote: [...] If that was allowed, wouldn't it have been a much simpler fix for CVE-2019-3016?

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-02 Thread Joao Martins
[late response - was on holiday yesterday] On 12/2/20 12:40 AM, Ankur Arora wrote: > On 2020-12-01 5:07 a.m., David Woodhouse wrote: >> On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote: >>> +static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn) >>> +{ >>> + struct shared_info

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-01 Thread Ankur Arora
On 2020-12-01 5:26 p.m., David Woodhouse wrote On Tue, 2020-12-01 at 16:40 -0800, Ankur Arora wrote: On 2020-12-01 5:07 a.m., David Woodhouse wrote: On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote: +static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn) +{ + struct

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-01 Thread David Woodhouse
On Tue, 2020-12-01 at 16:40 -0800, Ankur Arora wrote: > On 2020-12-01 5:07 a.m., David Woodhouse wrote: > > On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote: > > > +static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn) > > > +{ > > > + struct shared_info *shared_info; > > > +

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-01 Thread Ankur Arora
On 2020-12-01 5:07 a.m., David Woodhouse wrote: On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote: +static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn) +{ + struct shared_info *shared_info; + struct page *page; + + page = gfn_to_page(kvm, gfn); + if

Re: [PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2020-12-01 Thread David Woodhouse
On Wed, 2019-02-20 at 20:15 +, Joao Martins wrote: > +static int kvm_xen_shared_info_init(struct kvm *kvm, gfn_t gfn) > +{ > + struct shared_info *shared_info; > + struct page *page; > + > + page = gfn_to_page(kvm, gfn); > + if (is_error_page(page)) > +

[PATCH RFC 03/39] KVM: x86/xen: register shared_info page

2019-02-20 Thread Joao Martins
We add a new ioctl, XEN_HVM_SHARED_INFO, to allow hypervisor to know where the guest's shared info page is. Signed-off-by: Joao Martins --- arch/x86/include/asm/kvm_host.h | 3 +++ arch/x86/kvm/x86.c | 21 +++ arch/x86/kvm/xen.c | 60