Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-11 Thread Steven Rostedt
On Sun, 10 May 2020 17:59:27 +0800 Lai Jiangshan wrote: > Hello > > I think adding a small number of instructions to preempt_schedule_irq() > is sufficient to create the needed protected region between the start > of a function and the trampoline body. > > preempt_schedule_irq() { > + if

Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-11 Thread Steven Rostedt
On Sun, 10 May 2020 17:59:27 +0800 Lai Jiangshan wrote: > I think adding a small number of instructions to preempt_schedule_irq() > is sufficient to create the needed protected region between the start > of a function and the trampoline body. > > preempt_schedule_irq() { > + if

Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-10 Thread Paul E. McKenney
On Mon, May 11, 2020 at 08:06:29AM +0800, Lai Jiangshan wrote: > On Sun, May 10, 2020 at 11:49 PM Paul E. McKenney wrote: > > > > On Sun, May 10, 2020 at 05:59:27PM +0800, Lai Jiangshan wrote: > > > On Tue, Mar 17, 2020 at 6:03 AM Steven Rostedt > > > wrote: > > > > > > > > On Mon, 16 Mar 2020

Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-10 Thread Masami Hiramatsu
On Sun, 10 May 2020 17:59:27 +0800 Lai Jiangshan wrote: > On Tue, Mar 17, 2020 at 6:03 AM Steven Rostedt wrote: > > > > On Mon, 16 Mar 2020 17:45:40 -0400 > > Joel Fernandes wrote: > > > > > > > > > > Same for the function side (if not even more so). This would require > > > > adding > > > >

Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-10 Thread Lai Jiangshan
On Sun, May 10, 2020 at 11:49 PM Paul E. McKenney wrote: > > On Sun, May 10, 2020 at 05:59:27PM +0800, Lai Jiangshan wrote: > > On Tue, Mar 17, 2020 at 6:03 AM Steven Rostedt wrote: > > > > > > On Mon, 16 Mar 2020 17:45:40 -0400 > > > Joel Fernandes wrote: > > > > > > > > > > > > > Same for the

Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-10 Thread Paul E. McKenney
On Sun, May 10, 2020 at 05:59:27PM +0800, Lai Jiangshan wrote: > On Tue, Mar 17, 2020 at 6:03 AM Steven Rostedt wrote: > > > > On Mon, 16 Mar 2020 17:45:40 -0400 > > Joel Fernandes wrote: > > > > > > > > > > Same for the function side (if not even more so). This would require > > > > adding > >

Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-10 Thread Lai Jiangshan
On Tue, Mar 17, 2020 at 6:03 AM Steven Rostedt wrote: > > On Mon, 16 Mar 2020 17:45:40 -0400 > Joel Fernandes wrote: > > > > > > > Same for the function side (if not even more so). This would require > > > adding > > > a srcu_read_lock() to all functions that can be traced! That would be a > >