Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-07-02 Thread Rob Herring
On Wed, Jul 1, 2015 at 2:07 PM, Dr. H. Nikolaus Schaller wrote: > Hi, > > Am 01.07.2015 um 20:16 schrieb Rob Herring : > >> On Sun, Jun 28, 2015 at 2:46 PM, Marek Belisko wrote: >>> From: "H. Nikolaus Schaller" >>> >>> 1. add registered uart_ports to a search list >>> 2. provide a function to

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-07-02 Thread Rob Herring
On Wed, Jul 1, 2015 at 2:07 PM, Dr. H. Nikolaus Schaller h...@goldelico.com wrote: Hi, Am 01.07.2015 um 20:16 schrieb Rob Herring robherri...@gmail.com: On Sun, Jun 28, 2015 at 2:46 PM, Marek Belisko ma...@goldelico.com wrote: From: H. Nikolaus Schaller h...@goldelico.com 1. add registered

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-07-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 01.07.2015 um 20:16 schrieb Rob Herring : > On Sun, Jun 28, 2015 at 2:46 PM, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> 1. add registered uart_ports to a search list >> 2. provide a function to search an uart_port by phandle. This copies the >> mechanism how

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-07-01 Thread Rob Herring
On Sun, Jun 28, 2015 at 2:46 PM, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > 1. add registered uart_ports to a search list > 2. provide a function to search an uart_port by phandle. This copies the >mechanism how devm_usb_get_phy_by_phandle() works How does this relate to Neil's

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-07-01 Thread Rob Herring
On Sun, Jun 28, 2015 at 2:46 PM, Marek Belisko ma...@goldelico.com wrote: From: H. Nikolaus Schaller h...@goldelico.com 1. add registered uart_ports to a search list 2. provide a function to search an uart_port by phandle. This copies the mechanism how devm_usb_get_phy_by_phandle() works

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-07-01 Thread Dr. H. Nikolaus Schaller
Hi, Am 01.07.2015 um 20:16 schrieb Rob Herring robherri...@gmail.com: On Sun, Jun 28, 2015 at 2:46 PM, Marek Belisko ma...@goldelico.com wrote: From: H. Nikolaus Schaller h...@goldelico.com 1. add registered uart_ports to a search list 2. provide a function to search an uart_port by

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-30 Thread Sergei Zviagintsev
Hi, On Mon, Jun 29, 2015 at 06:44:23PM +0200, Dr. H. Nikolaus Schaller wrote: [...] > >> + list_for_each_entry(uart, _list, head) { > >> + if (node != uart->dev->of_node) > >> + continue; > >> + > >> + return uart; > > > > We can easily save three lines here

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-30 Thread Sergei Zviagintsev
Hi, On Mon, Jun 29, 2015 at 06:44:23PM +0200, Dr. H. Nikolaus Schaller wrote: [...] + list_for_each_entry(uart, uart_list, head) { + if (node != uart-dev-of_node) + continue; + + return uart; We can easily save three lines here :) Hm. We have

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-29 Thread Dr. H. Nikolaus Schaller
Hi, thanks for the comments. Am 28.06.2015 um 23:34 schrieb Sergei Zviagintsev : > Hi, > > Some comments below. > > On Sun, Jun 28, 2015 at 09:46:24PM +0200, Marek Belisko wrote: >> From: "H. Nikolaus Schaller" >> >> 1. add registered uart_ports to a search list >> 2. provide a function to

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-29 Thread Dr. H. Nikolaus Schaller
Hi, thanks for the comments. Am 28.06.2015 um 23:34 schrieb Sergei Zviagintsev ser...@s15v.net: Hi, Some comments below. On Sun, Jun 28, 2015 at 09:46:24PM +0200, Marek Belisko wrote: From: H. Nikolaus Schaller h...@goldelico.com 1. add registered uart_ports to a search list 2.

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-28 Thread Sergei Zviagintsev
Hi, Some comments below. On Sun, Jun 28, 2015 at 09:46:24PM +0200, Marek Belisko wrote: > From: "H. Nikolaus Schaller" > > 1. add registered uart_ports to a search list > 2. provide a function to search an uart_port by phandle. This copies the >mechanism how devm_usb_get_phy_by_phandle()

[PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-28 Thread Marek Belisko
From: "H. Nikolaus Schaller" 1. add registered uart_ports to a search list 2. provide a function to search an uart_port by phandle. This copies the mechanism how devm_usb_get_phy_by_phandle() works Signed-off-by: H. Nikolaus Schaller Signed-off-by: Marek Belisko ---

Re: [PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-28 Thread Sergei Zviagintsev
Hi, Some comments below. On Sun, Jun 28, 2015 at 09:46:24PM +0200, Marek Belisko wrote: From: H. Nikolaus Schaller h...@goldelico.com 1. add registered uart_ports to a search list 2. provide a function to search an uart_port by phandle. This copies the mechanism how

[PATCH RFC v2 1/3] tty: serial core: provide method to search uart by phandle

2015-06-28 Thread Marek Belisko
From: H. Nikolaus Schaller h...@goldelico.com 1. add registered uart_ports to a search list 2. provide a function to search an uart_port by phandle. This copies the mechanism how devm_usb_get_phy_by_phandle() works Signed-off-by: H. Nikolaus Schaller h...@goldelico.com Signed-off-by: Marek