Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC

2013-04-15 Thread Mark Brown
On Mon, Apr 15, 2013 at 04:36:51PM +0800, Axel Lin wrote: > The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct > selector in get_voltage_sel and set_voltage_sel. Applied, thanks. signature.asc Description: Digital signature

Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC

2013-04-15 Thread Bengt Jönsson
On 04/15/2013 10:36 AM, Axel Lin wrote: The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct selector in get_voltage_sel and set_voltage_sel. Signed-off-by: Axel Lin The patch is correct. Voltage selection is done with 0xc0. Acked-by: Bengt Jonsson --- Hi Bengt, I

[PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC

2013-04-15 Thread Axel Lin
The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct selector in get_voltage_sel and set_voltage_sel. Signed-off-by: Axel Lin --- Hi Bengt, I don't have the datasheet. Can you confirm if this fix is correct? BTW, can you also review a couple patches for ab8500 and

[PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC

2013-04-15 Thread Axel Lin
The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct selector in get_voltage_sel and set_voltage_sel. Signed-off-by: Axel Lin axel@ingics.com --- Hi Bengt, I don't have the datasheet. Can you confirm if this fix is correct? BTW, can you also review a couple patches

Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC

2013-04-15 Thread Bengt Jönsson
On 04/15/2013 10:36 AM, Axel Lin wrote: The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct selector in get_voltage_sel and set_voltage_sel. Signed-off-by: Axel Lin axel@ingics.com The patch is correct. Voltage selection is done with 0xc0. Acked-by: Bengt

Re: [PATCH RFT] regulator: ab8500: Fix voltage_shift setting for AB8540_LDO_DMIC

2013-04-15 Thread Mark Brown
On Mon, Apr 15, 2013 at 04:36:51PM +0800, Axel Lin wrote: The voltage_mask is 0xc0, thus we need to set voltage_shift = 6 to get correct selector in get_voltage_sel and set_voltage_sel. Applied, thanks. signature.asc Description: Digital signature