On 05/30/2016 10:52 AM, Axel Lin wrote:
> 2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski :
>> On 05/29/2016 01:16 PM, Axel Lin wrote:
>>> Current code can set ramp delay to a wrong setting that the return value
>>> from .set_voltage_time_sel is not enough for proper delay.
On 05/30/2016 10:52 AM, Axel Lin wrote:
> 2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski :
>> On 05/29/2016 01:16 PM, Axel Lin wrote:
>>> Current code can set ramp delay to a wrong setting that the return value
>>> from .set_voltage_time_sel is not enough for proper delay.
>>
>> I don't understand
2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski :
> On 05/29/2016 01:16 PM, Axel Lin wrote:
>> Current code can set ramp delay to a wrong setting that the return value
>> from .set_voltage_time_sel is not enough for proper delay.
>
> I don't understand what yo wanted to say
2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski :
> On 05/29/2016 01:16 PM, Axel Lin wrote:
>> Current code can set ramp delay to a wrong setting that the return value
>> from .set_voltage_time_sel is not enough for proper delay.
>
> I don't understand what yo wanted to say here. What wrong setting
On 05/29/2016 01:16 PM, Axel Lin wrote:
> Current code can set ramp delay to a wrong setting that the return value
> from .set_voltage_time_sel is not enough for proper delay.
I don't understand what yo wanted to say here. What wrong setting is
possible? Why do you mention set_voltage_time_sel()
On 05/29/2016 01:16 PM, Axel Lin wrote:
> Current code can set ramp delay to a wrong setting that the return value
> from .set_voltage_time_sel is not enough for proper delay.
I don't understand what yo wanted to say here. What wrong setting is
possible? Why do you mention set_voltage_time_sel()
Current code can set ramp delay to a wrong setting that the return value
from .set_voltage_time_sel is not enough for proper delay.
Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
Signed-off-by: Axel Lin
---
drivers/regulator/max8973-regulator.c |
Current code can set ramp delay to a wrong setting that the return value
from .set_voltage_time_sel is not enough for proper delay.
Fix the logic in .set_ramp_delay and also remove unused ret_val variable.
Signed-off-by: Axel Lin
---
drivers/regulator/max8973-regulator.c | 16 ++--
8 matches
Mail list logo