Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 Thread Krzysztof Kozlowski
On 05/30/2016 10:52 AM, Axel Lin wrote: > 2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski : >> On 05/29/2016 01:16 PM, Axel Lin wrote: >>> Current code can set ramp delay to a wrong setting that the return value >>> from .set_voltage_time_sel is not enough for proper delay.

Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 Thread Krzysztof Kozlowski
On 05/30/2016 10:52 AM, Axel Lin wrote: > 2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski : >> On 05/29/2016 01:16 PM, Axel Lin wrote: >>> Current code can set ramp delay to a wrong setting that the return value >>> from .set_voltage_time_sel is not enough for proper delay. >> >> I don't understand

Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 Thread Axel Lin
2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski : > On 05/29/2016 01:16 PM, Axel Lin wrote: >> Current code can set ramp delay to a wrong setting that the return value >> from .set_voltage_time_sel is not enough for proper delay. > > I don't understand what yo wanted to say

Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 Thread Axel Lin
2016-05-30 16:48 GMT+08:00 Krzysztof Kozlowski : > On 05/29/2016 01:16 PM, Axel Lin wrote: >> Current code can set ramp delay to a wrong setting that the return value >> from .set_voltage_time_sel is not enough for proper delay. > > I don't understand what yo wanted to say here. What wrong setting

Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 Thread Krzysztof Kozlowski
On 05/29/2016 01:16 PM, Axel Lin wrote: > Current code can set ramp delay to a wrong setting that the return value > from .set_voltage_time_sel is not enough for proper delay. I don't understand what yo wanted to say here. What wrong setting is possible? Why do you mention set_voltage_time_sel()

Re: [PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-30 Thread Krzysztof Kozlowski
On 05/29/2016 01:16 PM, Axel Lin wrote: > Current code can set ramp delay to a wrong setting that the return value > from .set_voltage_time_sel is not enough for proper delay. I don't understand what yo wanted to say here. What wrong setting is possible? Why do you mention set_voltage_time_sel()

[PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-29 Thread Axel Lin
Current code can set ramp delay to a wrong setting that the return value from .set_voltage_time_sel is not enough for proper delay. Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin --- drivers/regulator/max8973-regulator.c |

[PATCH RFT] regulator: max8972: Fix setting ramp delay

2016-05-29 Thread Axel Lin
Current code can set ramp delay to a wrong setting that the return value from .set_voltage_time_sel is not enough for proper delay. Fix the logic in .set_ramp_delay and also remove unused ret_val variable. Signed-off-by: Axel Lin --- drivers/regulator/max8973-regulator.c | 16 ++--