Re: [PATCH V1] vdpa_sim: reset must not run

2024-02-09 Thread Steven Sistare
On 1/22/2024 5:59 AM, Stefano Garzarella wrote: > On Mon, Jan 22, 2024 at 11:47:22AM +0100, Eugenio Perez Martin wrote: >> On Mon, Jan 22, 2024 at 11:22 AM Stefano Garzarella >> wrote: >>> >>> On Wed, Jan 17, 2024 at 11:23:23AM -0800, Steve Sistare wrote: >>> >vdpasim_do_reset sets running to

Re: Re: [PATCH V1] vdpa_sim: reset must not run

2024-01-22 Thread Stefano Garzarella
On Mon, Jan 22, 2024 at 11:47:22AM +0100, Eugenio Perez Martin wrote: On Mon, Jan 22, 2024 at 11:22 AM Stefano Garzarella wrote: On Wed, Jan 17, 2024 at 11:23:23AM -0800, Steve Sistare wrote: >vdpasim_do_reset sets running to true, which is wrong, as it allows >vdpasim_kick_vq to post work

Re: [PATCH V1] vdpa_sim: reset must not run

2024-01-22 Thread Eugenio Perez Martin
On Mon, Jan 22, 2024 at 11:22 AM Stefano Garzarella wrote: > > On Wed, Jan 17, 2024 at 11:23:23AM -0800, Steve Sistare wrote: > >vdpasim_do_reset sets running to true, which is wrong, as it allows > >vdpasim_kick_vq to post work requests before the device has been > >configured. To fix, do not

Re: [PATCH V1] vdpa_sim: reset must not run

2024-01-22 Thread Stefano Garzarella
On Wed, Jan 17, 2024 at 11:23:23AM -0800, Steve Sistare wrote: vdpasim_do_reset sets running to true, which is wrong, as it allows vdpasim_kick_vq to post work requests before the device has been configured. To fix, do not set running until VIRTIO_CONFIG_S_FEATURES_OK is set. Fixes:

Re: [PATCH V1] vdpa_sim: reset must not run

2024-01-21 Thread Jason Wang
On Thu, Jan 18, 2024 at 3:23 AM Steve Sistare wrote: > > vdpasim_do_reset sets running to true, which is wrong, as it allows > vdpasim_kick_vq to post work requests before the device has been > configured. To fix, do not set running until VIRTIO_CONFIG_S_FEATURES_OK > is set. > > Fixes:

[PATCH V1] vdpa_sim: reset must not run

2024-01-17 Thread Steve Sistare
vdpasim_do_reset sets running to true, which is wrong, as it allows vdpasim_kick_vq to post work requests before the device has been configured. To fix, do not set running until VIRTIO_CONFIG_S_FEATURES_OK is set. Fixes: 0c89e2a3a9d0 ("vdpa_sim: Implement suspend vdpa op") Signed-off-by: Steve