Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-08 Thread Robert Richter
On 02.12.16 10:27:43, Bjorn Helgaas wrote: > On Fri, Dec 02, 2016 at 11:45:00AM +0100, Robert Richter wrote: > > On 02.12.16 11:06:24, Tomasz Nowicki wrote: > > > On 02.12.2016 07:42, Duc Dang wrote: > > > > > >@@ -98,16 +98,16 @@ struct mcfg_fixup { > > > >{ "CAVIUM", "THUNDERX", rev, seg

Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-02 Thread Bjorn Helgaas
On Fri, Dec 02, 2016 at 11:45:00AM +0100, Robert Richter wrote: > On 02.12.16 11:06:24, Tomasz Nowicki wrote: > > On 02.12.2016 07:42, Duc Dang wrote: > > > >@@ -98,16 +98,16 @@ struct mcfg_fixup { > > >{ "CAVIUM", "THUNDERX", rev, seg, MCFG_BUS_ANY, \ > > >&pci_thu

Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-02 Thread Robert Richter
On 02.12.16 11:06:24, Tomasz Nowicki wrote: > On 02.12.2016 07:42, Duc Dang wrote: > >@@ -98,16 +98,16 @@ struct mcfg_fixup { > >{ "CAVIUM", "THUNDERX", rev, seg, MCFG_BUS_ANY, \ > >&pci_thunder_ecam_ops } > >/* SoC pass1.x */ > >- THUNDER_PEM_QUIRK(2, 0)

Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-02 Thread Tomasz Nowicki
On 02.12.2016 07:42, Duc Dang wrote: On Thu, Dec 1, 2016 at 9:50 PM, Jon Masters wrote: On 11/30/2016 07:28 PM, Bjorn Helgaas wrote: I'm hoping to end up with something like this: https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ecam&id=51ad4df79a9b7f2a66b346a46b21a7

Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Jon Masters
On 12/02/2016 01:42 AM, Duc Dang wrote: > On Thu, Dec 1, 2016 at 9:50 PM, Jon Masters wrote: >> On 11/30/2016 07:28 PM, Bjorn Helgaas wrote: >> >>> I'm hoping to end up with something like this: >>> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ecam&id=51ad4df79a9b7f2a

Re: [Linaro-acpi] [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Duc Dang
On Thu, Dec 1, 2016 at 9:50 PM, Jon Masters wrote: > On 11/30/2016 07:28 PM, Bjorn Helgaas wrote: > >> I'm hoping to end up with something like this: >> https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ecam&id=51ad4df79a9b7f2a66b346a46b21a785a2937469 > > The following bui

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Jon Masters
On 11/30/2016 07:28 PM, Bjorn Helgaas wrote: > I'm hoping to end up with something like this: > https://git.kernel.org/cgit/linux/kernel/git/helgaas/pci.git/commit/?h=pci/ecam&id=51ad4df79a9b7f2a66b346a46b21a785a2937469 The following build warnings happen using your branch on RHELSA7.3: drivers/

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Bjorn Helgaas
On Thu, Dec 01, 2016 at 02:54:50PM +, Lorenzo Pieralisi wrote: > On Thu, Dec 01, 2016 at 02:55:49PM +0100, Robert Richter wrote: > > Tomasz, Bjorn, > > > > On 01.12.16 09:49:51, Tomasz Nowicki wrote: > > > I put the picture together here (on top of your pci/ecam branch): > > > [1] > > > https

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Bjorn Helgaas
On Thu, Dec 01, 2016 at 02:55:49PM +0100, Robert Richter wrote: > Tomasz, Bjorn, > > On 01.12.16 09:49:51, Tomasz Nowicki wrote: > > I put the picture together here (on top of your pci/ecam branch): > > [1] > > https://github.com/semihalf-nowicki-tomasz/linux/commits/pci-quirks-thunderx-v2 > > p

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Bjorn Helgaas
On Thu, Dec 01, 2016 at 09:49:51AM +0100, Tomasz Nowicki wrote: > Hi Bjorn, > > On 01.12.2016 01:28, Bjorn Helgaas wrote: > >Hi Tomasz, > > > >On Tue, Nov 15, 2016 at 10:14:57AM +0100, Tomasz Nowicki wrote: > >>ThunderX PCIe controller to off-chip devices (so-called PEM) is not fully > >>compliant

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Lorenzo Pieralisi
On Thu, Dec 01, 2016 at 02:55:49PM +0100, Robert Richter wrote: > Tomasz, Bjorn, > > On 01.12.16 09:49:51, Tomasz Nowicki wrote: > > I put the picture together here (on top of your pci/ecam branch): > > [1] > > https://github.com/semihalf-nowicki-tomasz/linux/commits/pci-quirks-thunderx-v2 > > p

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Robert Richter
Tomasz, Bjorn, On 01.12.16 09:49:51, Tomasz Nowicki wrote: > I put the picture together here (on top of your pci/ecam branch): > [1] > https://github.com/semihalf-nowicki-tomasz/linux/commits/pci-quirks-thunderx-v2 please note that acpi_* functions must be protected with acpi_disabled or somethi

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-12-01 Thread Tomasz Nowicki
Hi Bjorn, On 01.12.2016 01:28, Bjorn Helgaas wrote: Hi Tomasz, On Tue, Nov 15, 2016 at 10:14:57AM +0100, Tomasz Nowicki wrote: ThunderX PCIe controller to off-chip devices (so-called PEM) is not fully compliant with ECAM standard. It uses non-standard configuration space accessors (see pci_thu

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-11-30 Thread Sinan Kaya
On 11/30/2016 10:48 PM, Bjorn Helgaas wrote: > On Wed, Nov 30, 2016 at 08:00:12PM -0500, Sinan Kaya wrote: >> Hi Bjorn, >> >> On 11/30/2016 7:28 PM, Bjorn Helgaas wrote: >>> Actually, that raises a question for qualcomm and hisi: in the DT >>> model, we use non-ECAM config accessors in the driver,

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-11-30 Thread Bjorn Helgaas
On Wed, Nov 30, 2016 at 08:00:12PM -0500, Sinan Kaya wrote: > Hi Bjorn, > > On 11/30/2016 7:28 PM, Bjorn Helgaas wrote: > > Actually, that raises a question for qualcomm and hisi: in the DT > > model, we use non-ECAM config accessors in the driver, but in the ACPI > > model, we use ECAM accessors.

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-11-30 Thread Sinan Kaya
Hi Bjorn, On 11/30/2016 7:28 PM, Bjorn Helgaas wrote: > Actually, that raises a question for qualcomm and hisi: in the DT > model, we use non-ECAM config accessors in the driver, but in the ACPI > model, we use ECAM accessors. It seems like the accessors should be > the same regardless of whether

Re: [PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-11-30 Thread Bjorn Helgaas
Hi Tomasz, On Tue, Nov 15, 2016 at 10:14:57AM +0100, Tomasz Nowicki wrote: > ThunderX PCIe controller to off-chip devices (so-called PEM) is not fully > compliant with ECAM standard. It uses non-standard configuration space > accessors (see pci_thunder_pem_ops) and custom configuration space granu

[PATCH V1 1/2] PCI: thunder: Enable ACPI PCI controller for ThunderX pass2.x silicon version

2016-11-15 Thread Tomasz Nowicki
ThunderX PCIe controller to off-chip devices (so-called PEM) is not fully compliant with ECAM standard. It uses non-standard configuration space accessors (see pci_thunder_pem_ops) and custom configuration space granulation (see bus_shift = 24). In order to access configuration space and probe PEM