Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-19 Thread Sinan Kaya
On 7/19/2016 11:28 AM, Alex Williamson wrote: > On Tue, 19 Jul 2016 10:49:54 -0400 > Sinan Kaya wrote: > >> On 7/18/2016 8:24 PM, Alex Williamson wrote: > nit, might make sense to replace EPERM with ENOENT and use EINVAL here. >>> > > Sure, will take

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-19 Thread Sinan Kaya
On 7/19/2016 11:28 AM, Alex Williamson wrote: > On Tue, 19 Jul 2016 10:49:54 -0400 > Sinan Kaya wrote: > >> On 7/18/2016 8:24 PM, Alex Williamson wrote: > nit, might make sense to replace EPERM with ENOENT and use EINVAL here. >>> > > Sure, will take carr of it. >

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-19 Thread Alex Williamson
On Tue, 19 Jul 2016 10:49:54 -0400 Sinan Kaya wrote: > On 7/18/2016 8:24 PM, Alex Williamson wrote: > >>> nit, might make sense to replace EPERM with ENOENT and use EINVAL here. > >>> > > > >> > > >> > Sure, will take carr of it. > >> > > >> > Anything else I need

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-19 Thread Alex Williamson
On Tue, 19 Jul 2016 10:49:54 -0400 Sinan Kaya wrote: > On 7/18/2016 8:24 PM, Alex Williamson wrote: > >>> nit, might make sense to replace EPERM with ENOENT and use EINVAL here. > >>> > > > >> > > >> > Sure, will take carr of it. > >> > > >> > Anything else I need to take care of? > >

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-19 Thread Sinan Kaya
On 7/18/2016 8:24 PM, Alex Williamson wrote: >>> nit, might make sense to replace EPERM with ENOENT and use EINVAL here. >>> > > >> > >> > Sure, will take carr of it. >> > >> > Anything else I need to take care of? > Not that I see, maybe just send a new version of this patch if the > changes

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-19 Thread Sinan Kaya
On 7/18/2016 8:24 PM, Alex Williamson wrote: >>> nit, might make sense to replace EPERM with ENOENT and use EINVAL here. >>> > > >> > >> > Sure, will take carr of it. >> > >> > Anything else I need to take care of? > Not that I see, maybe just send a new version of this patch if the > changes

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Alex Williamson
On Mon, 18 Jul 2016 20:16:50 -0400 ok...@codeaurora.org wrote: > On 2016-07-18 20:00, Alex Williamson wrote: > > On Mon, 18 Jul 2016 19:09:22 -0400 > > Sinan Kaya wrote: > > > >> The code is using the compatible DT string to associate a reset driver > >> with the actual

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Alex Williamson
On Mon, 18 Jul 2016 20:16:50 -0400 ok...@codeaurora.org wrote: > On 2016-07-18 20:00, Alex Williamson wrote: > > On Mon, 18 Jul 2016 19:09:22 -0400 > > Sinan Kaya wrote: > > > >> The code is using the compatible DT string to associate a reset driver > >> with the actual device itself. The

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread okaya
On 2016-07-18 20:00, Alex Williamson wrote: On Mon, 18 Jul 2016 19:09:22 -0400 Sinan Kaya wrote: The code is using the compatible DT string to associate a reset driver with the actual device itself. The compatible string does not exist on ACPI based systems. HID is the

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread okaya
On 2016-07-18 20:00, Alex Williamson wrote: On Mon, 18 Jul 2016 19:09:22 -0400 Sinan Kaya wrote: The code is using the compatible DT string to associate a reset driver with the actual device itself. The compatible string does not exist on ACPI based systems. HID is the unique identifier for a

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Alex Williamson
On Mon, 18 Jul 2016 19:09:22 -0400 Sinan Kaya wrote: > The code is using the compatible DT string to associate a reset driver > with the actual device itself. The compatible string does not exist on > ACPI based systems. HID is the unique identifier for a device driver >

Re: [PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Alex Williamson
On Mon, 18 Jul 2016 19:09:22 -0400 Sinan Kaya wrote: > The code is using the compatible DT string to associate a reset driver > with the actual device itself. The compatible string does not exist on > ACPI based systems. HID is the unique identifier for a device driver > instead. > >

[PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Sinan Kaya
The code is using the compatible DT string to associate a reset driver with the actual device itself. The compatible string does not exist on ACPI based systems. HID is the unique identifier for a device driver instead. Signed-off-by: Sinan Kaya ---

[PATCH V10 4/9] vfio: platform: add support for ACPI probe

2016-07-18 Thread Sinan Kaya
The code is using the compatible DT string to associate a reset driver with the actual device itself. The compatible string does not exist on ACPI based systems. HID is the unique identifier for a device driver instead. Signed-off-by: Sinan Kaya --- drivers/vfio/platform/vfio_platform_common.c