RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Ryan Lee
;; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable >amp reset > >On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote: >> On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee > wrote: > >> > >Not seeing a chang

RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Ryan Lee
;; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable >amp reset > >On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote: >> On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee > wrote: > >> > >Not seeing a chang

RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Ryan Lee
LKML ker...@vger.kernel.org>; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable >amp reset > >EXTERNAL EMAIL > > > >On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee > wrote: >> >> >-Original Message- >>

RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Ryan Lee
LKML ker...@vger.kernel.org>; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable >amp reset > >EXTERNAL EMAIL > > > >On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee > wrote: >> >> >-Original Message- >>

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Mark Brown
On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote: > On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee > wrote: > > >Not seeing a changelog here like I asked for :( > > Actually I added changelog as below. Do you mean this is not sufficient? > The text is probably sufficient but not in a

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-29 Thread Mark Brown
On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote: > On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee > wrote: > > >Not seeing a changelog here like I asked for :( > > Actually I added changelog as below. Do you mean this is not sufficient? > The text is probably sufficient but not in a

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Grant Grundler
inori Morimoto > >; Benson Leung > >; alsa-de...@alsa-project.org; linux- > >ker...@vger.kernel.org; ryan.lee.ma...@gmail.com > >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable > >amp reset > > > >On Wed, Nov 28, 2018 at 03:20:16AM +000

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Grant Grundler
inori Morimoto > >; Benson Leung > >; alsa-de...@alsa-project.org; linux- > >ker...@vger.kernel.org; ryan.lee.ma...@gmail.com > >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable > >amp reset > > > >On Wed, Nov 28, 2018 at 03:20:16AM +000

RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Ryan Lee
.@vger.kernel.org; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable >amp reset > >On Wed, Nov 28, 2018 at 03:20:16AM +, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- > >Not seeing a changelog here like I as

RE: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Ryan Lee
.@vger.kernel.org; ryan.lee.ma...@gmail.com >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable >amp reset > >On Wed, Nov 28, 2018 at 03:20:16AM +, Ryan Lee wrote: >> Signed-off-by: Ryan Lee >> --- > >Not seeing a changelog here like I as

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Mark Brown
On Wed, Nov 28, 2018 at 03:20:16AM +, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- Not seeing a changelog here like I asked for :( > Changes : Created max98373_reset function to minimize code duplication. > Changed regmap_write to regmap_update_bits. Other bits except LSB >

Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-28 Thread Mark Brown
On Wed, Nov 28, 2018 at 03:20:16AM +, Ryan Lee wrote: > Signed-off-by: Ryan Lee > --- Not seeing a changelog here like I asked for :( > Changes : Created max98373_reset function to minimize code duplication. > Changed regmap_write to regmap_update_bits. Other bits except LSB >

[PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changes since v1 : Removed unusual repeat for amp software reset and verification. Amp software reset will be performed once and it repeats verification maximum 3 times if it is failed. Wait 10ms before every verification trial.

[PATCH V2] ASoC: max98373: Added max98373_reset for stable amp reset

2018-11-27 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changes since v1 : Removed unusual repeat for amp software reset and verification. Amp software reset will be performed once and it repeats verification maximum 3 times if it is failed. Wait 10ms before every verification trial.