Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-29 Thread Sinan Kaya
Bjorn, On 5/25/2018 3:10 PM, Bjorn Helgaas wrote: > On Fri, May 25, 2018 at 09:30:59AM -0400, Sinan Kaya wrote: >> On 5/24/2018 2:35 PM, Bjorn Helgaas wrote: >>> That sounds like a reasonable idea, and it is definitely another can >>> of worms. I looked briefly at some of the .shutdown() cases:

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-28 Thread Sinan Kaya
On 5/24/2018 6:37 AM, Don Brace wrote: >> But we really need guidance from an hpsa expert. I don't know the >> filesystem/SCSI/hpsa details. >> >> Bjorn > It's most likely OCSD traffic that will stop when bus mastering is turned off. > So, I'll run some tests on my end before ACKing your patch.

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-25 Thread okaya
On 2018-05-25 15:10, Bjorn Helgaas wrote: On Fri, May 25, 2018 at 09:30:59AM -0400, Sinan Kaya wrote: On 5/24/2018 2:35 PM, Bjorn Helgaas wrote: > That sounds like a reasonable idea, and it is definitely another can > of worms. I looked briefly at some of the .shutdown() cases: should we

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-25 Thread Bjorn Helgaas
On Fri, May 25, 2018 at 09:30:59AM -0400, Sinan Kaya wrote: > On 5/24/2018 2:35 PM, Bjorn Helgaas wrote: > > That sounds like a reasonable idea, and it is definitely another can > > of worms. I looked briefly at some of the .shutdown() cases: > > should we throw it into 4.18 and see what

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-25 Thread Sinan Kaya
On 5/24/2018 2:35 PM, Bjorn Helgaas wrote: > That sounds like a reasonable idea, and it is definitely another can > of worms. I looked briefly at some of the .shutdown() cases: should we throw it into 4.18 and see what happens? -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-24 Thread Bjorn Helgaas
On Wed, May 23, 2018 at 06:57:18PM -0400, Sinan Kaya wrote: > On 5/23/2018 5:32 PM, Bjorn Helgaas wrote: > > > > The crash seems to indicate that the hpsa device attempted a DMA after > > we cleared the Root Port's PCI_COMMAND_MASTER, which means > > hpsa_shutdown() didn't stop DMA from the

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-24 Thread okaya
On 2018-05-24 09:07, Bjorn Helgaas wrote: On Thu, May 24, 2018 at 07:43:05AM -0400, Sinan Kaya wrote: On 5/23/2018 6:57 PM, Sinan Kaya wrote: >> The crash seems to indicate that the hpsa device attempted a DMA after >> we cleared the Root Port's PCI_COMMAND_MASTER, which means >>

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-24 Thread Bjorn Helgaas
On Thu, May 24, 2018 at 07:43:05AM -0400, Sinan Kaya wrote: > On 5/23/2018 6:57 PM, Sinan Kaya wrote: > >> The crash seems to indicate that the hpsa device attempted a DMA after > >> we cleared the Root Port's PCI_COMMAND_MASTER, which means > >> hpsa_shutdown() didn't stop DMA from the device (it

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-24 Thread Sinan Kaya
On 5/23/2018 6:57 PM, Sinan Kaya wrote: >> The crash seems to indicate that the hpsa device attempted a DMA after >> we cleared the Root Port's PCI_COMMAND_MASTER, which means >> hpsa_shutdown() didn't stop DMA from the device (it looks like *most* >> shutdown methods don't disable device DMA, so

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-23 Thread Sinan Kaya
On 5/23/2018 5:32 PM, Bjorn Helgaas wrote: > > The crash seems to indicate that the hpsa device attempted a DMA after > we cleared the Root Port's PCI_COMMAND_MASTER, which means > hpsa_shutdown() didn't stop DMA from the device (it looks like *most* > shutdown methods don't disable device DMA,

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-23 Thread Bjorn Helgaas
[-cc Gabriele (invalid email address)] [+cc Don, esc.storagedev, linux-scsi since hpsa is involved] Background for newcomers: Ryan reported a panic on shutdown/reboot [1] on DL360 Gen9. I think the problem is that the shutdown path clears PCI_COMMAND_MASTER on the Root Port leading to an

[PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-22 Thread Sinan Kaya
'Commit cc27b735ad3a ("PCI/portdrv: Turn off PCIe services during shutdown")' has been added to kernel to shutdown pending PCIe port service interrupts during reboot so that a newly started kexec kernel wouldn't observe pending interrupts. pcie_port_device_remove() is disabling the root port and