Re: [PATCH V2] atmel: fix a race between fw_load and data free

hi, yes, we can't guarantee MXT_FW_RESET_TIME is enough. patch v3 is sent out :) thanks xinhui On 2015年05月14日 19:31, Nick Dyer wrote: Hi- This looks like a good tidy up, one minor comment: On 15/05/15 12:19, Pan Xinhui wrote: +mxt_wait_for_completion(data, &data->fw_load_completi

Re: [PATCH V2] atmel: fix a race between fw_load and data free

Hi- This looks like a good tidy up, one minor comment: On 15/05/15 12:19, Pan Xinhui wrote: > +mxt_wait_for_completion(data, &data->fw_load_completion, > +MXT_FW_RESET_TIME); this should probably just be wait_for_completion(&data->fw_load_completion); rather than timing

[PATCH V2] atmel: fix a race between fw_load and data free

mxt_probe() may fail at last step, or we jsut unload mxt module soon. the queue_work scheduled by request_firmware_nowait may run later, and then access some data which is freed. To handle this issue, add fw_load_completion field in mxt_data. then we wait for it complete both in probe error path