Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-26 Thread Daniel Lezcano
On 01/26/2015 10:43 AM, Thomas Gleixner wrote: On Sun, 25 Jan 2015, Daniel Lezcano wrote: +static inline void rk_timer_set_mode(enum clock_event_mode mode, +struct clock_event_device *ce) +{ + switch (mode) { + case CLOCK_EVT_MODE_PERIODIC: +

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-26 Thread Thomas Gleixner
On Sun, 25 Jan 2015, Daniel Lezcano wrote: > +static inline void rk_timer_set_mode(enum clock_event_mode mode, > + struct clock_event_device *ce) > +{ > + switch (mode) { > + case CLOCK_EVT_MODE_PERIODIC: > + rk_timer_disable(ce); > +

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-26 Thread Daniel Lezcano
On 01/26/2015 02:25 AM, Kever Yang wrote: Hi Daniel, Hi Kever, [ ... ] +static inline int rk_timer_set_next_event(unsigned long cycles, + struct clock_event_device *ce) +{ +rk_timer_disable(ce); +rk_timer_update_counter(cycles, ce); +rk_timer_enable(ce,

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-26 Thread Daniel Lezcano
On 01/26/2015 10:43 AM, Thomas Gleixner wrote: On Sun, 25 Jan 2015, Daniel Lezcano wrote: +static inline void rk_timer_set_mode(enum clock_event_mode mode, +struct clock_event_device *ce) +{ + switch (mode) { + case CLOCK_EVT_MODE_PERIODIC: +

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-26 Thread Daniel Lezcano
On 01/26/2015 02:25 AM, Kever Yang wrote: Hi Daniel, Hi Kever, [ ... ] +static inline int rk_timer_set_next_event(unsigned long cycles, + struct clock_event_device *ce) +{ +rk_timer_disable(ce); +rk_timer_update_counter(cycles, ce); +rk_timer_enable(ce,

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-26 Thread Thomas Gleixner
On Sun, 25 Jan 2015, Daniel Lezcano wrote: +static inline void rk_timer_set_mode(enum clock_event_mode mode, + struct clock_event_device *ce) +{ + switch (mode) { + case CLOCK_EVT_MODE_PERIODIC: + rk_timer_disable(ce); +

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Kever Yang
Hi Daniel, On 01/25/2015 05:42 PM, Daniel Lezcano wrote: The rk3288 board uses the architected timers and these ones are shutdown when the cpu is powered down. There is a need of a broadcast timer in this case to ensure proper wakeup when the cpus are in sleep mode and a timer expires. This

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Heiko Stübner
Hi Daniel, Am Sonntag, 25. Januar 2015, 22:16:10 schrieb Daniel Lezcano: > On 01/25/2015 09:52 PM, Heiko Stübner wrote: > > one big request and some more style nitpicks :-) > > > > With the nitpicks fixed > > Reviewed-by: Heiko Stuebner > > > > > > Before applying this patch could you drop

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Daniel Lezcano
On 01/25/2015 09:52 PM, Heiko Stübner wrote: Hi Daniel, one big request and some more style nitpicks :-) With the nitpicks fixed Reviewed-by: Heiko Stuebner Before applying this patch could you drop the rk3288.dtsi change please? Instead I'd like to add the following patch separately to

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Heiko Stübner
Hi Daniel, one big request and some more style nitpicks :-) With the nitpicks fixed Reviewed-by: Heiko Stuebner Before applying this patch could you drop the rk3288.dtsi change please? Instead I'd like to add the following patch separately to _my_ devicetree branch for 3.20. I already wasn't

[PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Daniel Lezcano
The rk3288 board uses the architected timers and these ones are shutdown when the cpu is powered down. There is a need of a broadcast timer in this case to ensure proper wakeup when the cpus are in sleep mode and a timer expires. This driver provides the basic timer functionnality as a backup for

[PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Daniel Lezcano
The rk3288 board uses the architected timers and these ones are shutdown when the cpu is powered down. There is a need of a broadcast timer in this case to ensure proper wakeup when the cpus are in sleep mode and a timer expires. This driver provides the basic timer functionnality as a backup for

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Heiko Stübner
Hi Daniel, Am Sonntag, 25. Januar 2015, 22:16:10 schrieb Daniel Lezcano: On 01/25/2015 09:52 PM, Heiko Stübner wrote: one big request and some more style nitpicks :-) With the nitpicks fixed Reviewed-by: Heiko Stuebner he...@sntech.de Before applying this patch could you drop

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Kever Yang
Hi Daniel, On 01/25/2015 05:42 PM, Daniel Lezcano wrote: The rk3288 board uses the architected timers and these ones are shutdown when the cpu is powered down. There is a need of a broadcast timer in this case to ensure proper wakeup when the cpus are in sleep mode and a timer expires. This

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Heiko Stübner
Hi Daniel, one big request and some more style nitpicks :-) With the nitpicks fixed Reviewed-by: Heiko Stuebner he...@sntech.de Before applying this patch could you drop the rk3288.dtsi change please? Instead I'd like to add the following patch separately to _my_ devicetree branch for 3.20. I

Re: [PATCH V2] clockevents: rockchip: Add rockchip timer for rk3288

2015-01-25 Thread Daniel Lezcano
On 01/25/2015 09:52 PM, Heiko Stübner wrote: Hi Daniel, one big request and some more style nitpicks :-) With the nitpicks fixed Reviewed-by: Heiko Stuebner he...@sntech.de Before applying this patch could you drop the rk3288.dtsi change please? Instead I'd like to add the following patch