Re: [PATCH V2] nvme-pci: set cq_vector to -1 if io queue setup fails

2018-02-26 Thread Keith Busch
On Thu, Feb 15, 2018 at 07:13:41PM +0800, Jianchao Wang wrote: > nvme cq irq is freed based on queue_count. When the sq/cq creation > fails, irq will not be setup. free_irq will warn 'Try to free > already-free irq'. > > To fix it, set the nvmeq->cq_vector to -1, then nvme_suspend_queue > will

Re: [PATCH V2] nvme-pci: set cq_vector to -1 if io queue setup fails

2018-02-26 Thread Keith Busch
On Thu, Feb 15, 2018 at 07:13:41PM +0800, Jianchao Wang wrote: > nvme cq irq is freed based on queue_count. When the sq/cq creation > fails, irq will not be setup. free_irq will warn 'Try to free > already-free irq'. > > To fix it, set the nvmeq->cq_vector to -1, then nvme_suspend_queue > will

Re: [PATCH V2] nvme-pci: set cq_vector to -1 if io queue setup fails

2018-02-24 Thread jianchao.wang
Hi Keith Can you take a review on this ? Thanks in advance Really appreciate Jianchao On 02/15/2018 07:13 PM, Jianchao Wang wrote: > nvme cq irq is freed based on queue_count. When the sq/cq creation > fails, irq will not be setup. free_irq will warn 'Try to free > already-free irq'. > > To

Re: [PATCH V2] nvme-pci: set cq_vector to -1 if io queue setup fails

2018-02-24 Thread jianchao.wang
Hi Keith Can you take a review on this ? Thanks in advance Really appreciate Jianchao On 02/15/2018 07:13 PM, Jianchao Wang wrote: > nvme cq irq is freed based on queue_count. When the sq/cq creation > fails, irq will not be setup. free_irq will warn 'Try to free > already-free irq'. > > To

[PATCH V2] nvme-pci: set cq_vector to -1 if io queue setup fails

2018-02-15 Thread Jianchao Wang
nvme cq irq is freed based on queue_count. When the sq/cq creation fails, irq will not be setup. free_irq will warn 'Try to free already-free irq'. To fix it, set the nvmeq->cq_vector to -1, then nvme_suspend_queue will ignore it. Change log: V1 -> V2 - Follow Keith's suggestion, just set

[PATCH V2] nvme-pci: set cq_vector to -1 if io queue setup fails

2018-02-15 Thread Jianchao Wang
nvme cq irq is freed based on queue_count. When the sq/cq creation fails, irq will not be setup. free_irq will warn 'Try to free already-free irq'. To fix it, set the nvmeq->cq_vector to -1, then nvme_suspend_queue will ignore it. Change log: V1 -> V2 - Follow Keith's suggestion, just set