Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-31 Thread Shawn Guo
On Thu, Aug 31, 2017 at 06:30:48PM -0700, Stephen Boyd wrote: > On 08/31, Shawn Guo wrote: > > On Wed, Aug 30, 2017 at 02:02:03PM -0700, Stephen Boyd wrote: > > > On 08/26, Shawn Guo wrote: > > > > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > > > > > > > Right. Does the

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-31 Thread Shawn Guo
On Thu, Aug 31, 2017 at 06:30:48PM -0700, Stephen Boyd wrote: > On 08/31, Shawn Guo wrote: > > On Wed, Aug 30, 2017 at 02:02:03PM -0700, Stephen Boyd wrote: > > > On 08/26, Shawn Guo wrote: > > > > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > > > > > > > Right. Does the

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-31 Thread Stephen Boyd
On 08/31, Shawn Guo wrote: > On Wed, Aug 30, 2017 at 02:02:03PM -0700, Stephen Boyd wrote: > > On 08/26, Shawn Guo wrote: > > > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > > > > > Right. Does the GPIO work? If so, it sounds like the read/write > > > > access checks in

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-31 Thread Stephen Boyd
On 08/31, Shawn Guo wrote: > On Wed, Aug 30, 2017 at 02:02:03PM -0700, Stephen Boyd wrote: > > On 08/26, Shawn Guo wrote: > > > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > > > > > Right. Does the GPIO work? If so, it sounds like the read/write > > > > access checks in

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-31 Thread Shawn Guo
On Wed, Aug 30, 2017 at 02:02:03PM -0700, Stephen Boyd wrote: > On 08/26, Shawn Guo wrote: > > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > > > Right. Does the GPIO work? If so, it sounds like the read/write > > > access checks in spmi pmic arb don't work properly. > > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-31 Thread Shawn Guo
On Wed, Aug 30, 2017 at 02:02:03PM -0700, Stephen Boyd wrote: > On 08/26, Shawn Guo wrote: > > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > > > Right. Does the GPIO work? If so, it sounds like the read/write > > > access checks in spmi pmic arb don't work properly. > > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-30 Thread Stephen Boyd
On 08/26, Shawn Guo wrote: > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > Right. Does the GPIO work? If so, it sounds like the read/write > > access checks in spmi pmic arb don't work properly. > > The check works. With the check in there, PM8916 GPIO doesn't work. >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-30 Thread Stephen Boyd
On 08/26, Shawn Guo wrote: > On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > > > > Right. Does the GPIO work? If so, it sounds like the read/write > > access checks in spmi pmic arb don't work properly. > > The check works. With the check in there, PM8916 GPIO doesn't work. >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Shawn Guo
On Mon, Aug 28, 2017 at 04:27:54PM +0800, Fenglin Wu wrote: > On 8/22/2017 4:55 PM, Shawn Guo wrote: > >On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > >>On 08/18/2017 08:28 AM, Kiran Gunda wrote: > >>>The peripheral ownership check is not necessary on single master > >>>platforms.

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Shawn Guo
On Mon, Aug 28, 2017 at 04:27:54PM +0800, Fenglin Wu wrote: > On 8/22/2017 4:55 PM, Shawn Guo wrote: > >On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > >>On 08/18/2017 08:28 AM, Kiran Gunda wrote: > >>>The peripheral ownership check is not necessary on single master > >>>platforms.

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Shawn Guo
On Mon, Aug 28, 2017 at 01:53:28PM +0200, Greg KH wrote: > On Fri, Aug 18, 2017 at 08:58:29PM +0530, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > Signed-off-by: Kiran Gunda

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Shawn Guo
On Mon, Aug 28, 2017 at 01:53:28PM +0200, Greg KH wrote: > On Fri, Aug 18, 2017 at 08:58:29PM +0530, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > Signed-off-by: Kiran Gunda

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Greg KH
On Fri, Aug 18, 2017 at 08:58:29PM +0530, Kiran Gunda wrote: > The peripheral ownership check is not necessary on single master > platforms. Hence, enforce the peripheral ownership check optionally. > > Signed-off-by: Kiran Gunda > Tested-by: Shawn Guo

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Greg KH
On Fri, Aug 18, 2017 at 08:58:29PM +0530, Kiran Gunda wrote: > The peripheral ownership check is not necessary on single master > platforms. Hence, enforce the peripheral ownership check optionally. > > Signed-off-by: Kiran Gunda > Tested-by: Shawn Guo > --- > v2: > Fixed the commit

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Fenglin Wu
On 8/22/2017 4:55 PM, Shawn Guo wrote: On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: On 08/18/2017 08:28 AM, Kiran Gunda wrote: The peripheral ownership check is not necessary on single master platforms. Hence, enforce the peripheral ownership check optionally. Signed-off-by:

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-28 Thread Fenglin Wu
On 8/22/2017 4:55 PM, Shawn Guo wrote: On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: On 08/18/2017 08:28 AM, Kiran Gunda wrote: The peripheral ownership check is not necessary on single master platforms. Hence, enforce the peripheral ownership check optionally. Signed-off-by:

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-25 Thread Shawn Guo
On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > On 08/25, Shawn Guo wrote: > > On Thu, Aug 24, 2017 at 11:37:01AM -0700, Stephen Boyd wrote: > > > On 08/24, Shawn Guo wrote: > > > > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > > > > Also, I see that on v4.13-rc

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-25 Thread Shawn Guo
On Fri, Aug 25, 2017 at 04:18:18PM -0700, Stephen Boyd wrote: > On 08/25, Shawn Guo wrote: > > On Thu, Aug 24, 2017 at 11:37:01AM -0700, Stephen Boyd wrote: > > > On 08/24, Shawn Guo wrote: > > > > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > > > > Also, I see that on v4.13-rc

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-25 Thread Stephen Boyd
On 08/25, Shawn Guo wrote: > On Thu, Aug 24, 2017 at 11:37:01AM -0700, Stephen Boyd wrote: > > On 08/24, Shawn Guo wrote: > > > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > > > Also, I see that on v4.13-rc series the read/write checks are > > > > causing the led driver to fail

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-25 Thread Stephen Boyd
On 08/25, Shawn Guo wrote: > On Thu, Aug 24, 2017 at 11:37:01AM -0700, Stephen Boyd wrote: > > On 08/24, Shawn Guo wrote: > > > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > > > Also, I see that on v4.13-rc series the read/write checks are > > > > causing the led driver to fail

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-25 Thread Shawn Guo
On Thu, Aug 24, 2017 at 11:37:01AM -0700, Stephen Boyd wrote: > On 08/24, Shawn Guo wrote: > > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > > Also, I see that on v4.13-rc series the read/write checks are > > > causing the led driver to fail in a different way: > > > > > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-25 Thread Shawn Guo
On Thu, Aug 24, 2017 at 11:37:01AM -0700, Stephen Boyd wrote: > On 08/24, Shawn Guo wrote: > > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > > Also, I see that on v4.13-rc series the read/write checks are > > > causing the led driver to fail in a different way: > > > > > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-24 Thread Stephen Boyd
On 08/24, Shawn Guo wrote: > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > Also, I see that on v4.13-rc series the read/write checks are > > causing the led driver to fail in a different way: > > > > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc040 >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-24 Thread Stephen Boyd
On 08/24, Shawn Guo wrote: > On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > > Also, I see that on v4.13-rc series the read/write checks are > > causing the led driver to fail in a different way: > > > > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc040 >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-24 Thread Shawn Guo
On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > Also, I see that on v4.13-rc series the read/write checks are > causing the led driver to fail in a different way: > > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc040 > qcom-spmi-gpio

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-24 Thread Shawn Guo
On Tue, Aug 22, 2017 at 01:31:32PM -0700, Stephen Boyd wrote: > Also, I see that on v4.13-rc series the read/write checks are > causing the led driver to fail in a different way: > > spmi spmi-0: error: impermissible write to peripheral sid:0 addr:0xc040 > qcom-spmi-gpio

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-23 Thread kgunda
On 2017-08-23 02:01, Stephen Boyd wrote: On 08/22, Shawn Guo wrote: On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-23 Thread kgunda
On 2017-08-23 02:01, Stephen Boyd wrote: On 08/22, Shawn Guo wrote: On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-22 Thread Stephen Boyd
On 08/22, Shawn Guo wrote: > On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > > The peripheral ownership check is not necessary on single master > > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-22 Thread Stephen Boyd
On 08/22, Shawn Guo wrote: > On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > > The peripheral ownership check is not necessary on single master > > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-22 Thread Shawn Guo
On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > Signed-off-by: Kiran Gunda

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-22 Thread Shawn Guo
On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > Signed-off-by: Kiran Gunda > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-22 Thread Shawn Guo
On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > Signed-off-by: Kiran Gunda

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-22 Thread Shawn Guo
On Mon, Aug 21, 2017 at 04:18:58PM -0700, Stephen Boyd wrote: > On 08/18/2017 08:28 AM, Kiran Gunda wrote: > > The peripheral ownership check is not necessary on single master > > platforms. Hence, enforce the peripheral ownership check optionally. > > > > Signed-off-by: Kiran Gunda > >

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-21 Thread Stephen Boyd
On 08/18/2017 08:28 AM, Kiran Gunda wrote: > The peripheral ownership check is not necessary on single master > platforms. Hence, enforce the peripheral ownership check optionally. > > Signed-off-by: Kiran Gunda > Tested-by: Shawn Guo > --- This

Re: [PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-21 Thread Stephen Boyd
On 08/18/2017 08:28 AM, Kiran Gunda wrote: > The peripheral ownership check is not necessary on single master > platforms. Hence, enforce the peripheral ownership check optionally. > > Signed-off-by: Kiran Gunda > Tested-by: Shawn Guo > --- This sounds like a band-aid. Isn't the gpio driver

[PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-18 Thread Kiran Gunda
The peripheral ownership check is not necessary on single master platforms. Hence, enforce the peripheral ownership check optionally. Signed-off-by: Kiran Gunda Tested-by: Shawn Guo --- v2: Fixed the commit message. Added Shawn's

[PATCH V2] spmi: pmic-arb: Enforce the ownership check optionally

2017-08-18 Thread Kiran Gunda
The peripheral ownership check is not necessary on single master platforms. Hence, enforce the peripheral ownership check optionally. Signed-off-by: Kiran Gunda Tested-by: Shawn Guo --- v2: Fixed the commit message. Added Shawn's 'Tested-by' tag. v1: This patch depends