Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-14 Thread Arnd Bergmann
On Tuesday 14 January 2014 10:35:33 Feng Kan wrote: > On Mon, Jan 13, 2014 at 10:06 PM, Arnd Bergmann wrote: > > On Tuesday 14 January 2014, Feng Kan wrote: > >> > >> > > >> > Is this related to the standard ARM SCU that manages multiprocessor > >> > systems, or a different unit that uses the

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-14 Thread Feng Kan
On Mon, Jan 13, 2014 at 10:06 PM, Arnd Bergmann wrote: > On Tuesday 14 January 2014, Feng Kan wrote: >> >> > >> > Is this related to the standard ARM SCU that manages multiprocessor >> > systems, or a different unit that uses the same name? >> >> FKAN: You mean the snoop control unit in ARM. This

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-14 Thread Feng Kan
On Mon, Jan 13, 2014 at 10:06 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 14 January 2014, Feng Kan wrote: Is this related to the standard ARM SCU that manages multiprocessor systems, or a different unit that uses the same name? FKAN: You mean the snoop control unit in ARM. This is

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-14 Thread Arnd Bergmann
On Tuesday 14 January 2014 10:35:33 Feng Kan wrote: On Mon, Jan 13, 2014 at 10:06 PM, Arnd Bergmann a...@arndb.de wrote: On Tuesday 14 January 2014, Feng Kan wrote: Is this related to the standard ARM SCU that manages multiprocessor systems, or a different unit that uses the same

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Arnd Bergmann
On Tuesday 14 January 2014, Feng Kan wrote: > > > > > Is this related to the standard ARM SCU that manages multiprocessor > > systems, or a different unit that uses the same name? > > FKAN: You mean the snoop control unit in ARM. This is different from > that, the main function of this unit is

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Feng Kan
> > Is this related to the standard ARM SCU that manages multiprocessor > systems, or a different unit that uses the same name? FKAN: You mean the snoop control unit in ARM. This is different from that, the main function of this unit is clk control. > > Since this is a global register range with

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Arnd Bergmann
On Monday 13 January 2014, Feng Kan wrote: > FKAN: I could remove this dts node and create another dts node that > describe the range of registers on the SCU and use that node in this driver. > I am not sure which subsystem I can use to handle this case, I do see a reset > subsystem in the kernel

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Feng Kan
> That is not what I was asking about. > > The problem with your binding is that it doesn't seem to describe > the hardware structure at all, but rather try to invent devices > because of how it's convenient for how you write the Linux drivers. > > This is never a good idea and it will become a

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Arnd Bergmann
On Thursday 09 January 2014, Feng Kan wrote: > On Wed, Jan 8, 2014 at 2:08 AM, Arnd Bergmann wrote: > > On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote: > >> > + > >> > +Example: > >> > + > >> > + reboot@0 { > >> > + compatible = "apm,xgene-reboot"; > >> > +

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Arnd Bergmann
On Thursday 09 January 2014, Feng Kan wrote: On Wed, Jan 8, 2014 at 2:08 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote: + +Example: + + reboot@0 { + compatible = apm,xgene-reboot; + reg = 0x0

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Feng Kan
That is not what I was asking about. The problem with your binding is that it doesn't seem to describe the hardware structure at all, but rather try to invent devices because of how it's convenient for how you write the Linux drivers. This is never a good idea and it will become a problem

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Arnd Bergmann
On Monday 13 January 2014, Feng Kan wrote: FKAN: I could remove this dts node and create another dts node that describe the range of registers on the SCU and use that node in this driver. I am not sure which subsystem I can use to handle this case, I do see a reset subsystem in the kernel but

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Feng Kan
Is this related to the standard ARM SCU that manages multiprocessor systems, or a different unit that uses the same name? FKAN: You mean the snoop control unit in ARM. This is different from that, the main function of this unit is clk control. Since this is a global register range with a

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-13 Thread Arnd Bergmann
On Tuesday 14 January 2014, Feng Kan wrote: Is this related to the standard ARM SCU that manages multiprocessor systems, or a different unit that uses the same name? FKAN: You mean the snoop control unit in ARM. This is different from that, the main function of this unit is clk

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-10 Thread Feng Kan
On Wed, Jan 8, 2014 at 2:05 AM, Mark Rutland wrote: > On Tue, Jan 07, 2014 at 10:50:36PM +, Feng Kan wrote: >> Add X-Gene reboot device tree node documentation. >> >> Signed-off-by: Feng Kan >> --- >> .../devicetree/bindings/arm64/xgene/reboot.txt | 10 ++ >> 1 files changed,

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-10 Thread Feng Kan
On Wed, Jan 8, 2014 at 2:05 AM, Mark Rutland mark.rutl...@arm.com wrote: On Tue, Jan 07, 2014 at 10:50:36PM +, Feng Kan wrote: Add X-Gene reboot device tree node documentation. Signed-off-by: Feng Kan f...@apm.com --- .../devicetree/bindings/arm64/xgene/reboot.txt | 10 ++

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-09 Thread Feng Kan
On Wed, Jan 8, 2014 at 2:08 AM, Arnd Bergmann wrote: > On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote: >> > + >> > +Example: >> > + >> > + reboot@0 { >> > + compatible = "apm,xgene-reboot"; >> > + reg = <0x0 0x1714 0x0 0x4>; >> > + }; >> >> Given this

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-09 Thread Feng Kan
On Wed, Jan 8, 2014 at 2:08 AM, Arnd Bergmann a...@arndb.de wrote: On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote: + +Example: + + reboot@0 { + compatible = apm,xgene-reboot; + reg = 0x0 0x1714 0x0 0x4; + }; Given this seems to be a

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote: > > + > > +Example: > > + > > + reboot@0 { > > + compatible = "apm,xgene-reboot"; > > + reg = <0x0 0x1714 0x0 0x4>; > > + }; > > Given this seems to be a 64-bit address, the unit address should >

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-08 Thread Mark Rutland
On Tue, Jan 07, 2014 at 10:50:36PM +, Feng Kan wrote: > Add X-Gene reboot device tree node documentation. > > Signed-off-by: Feng Kan > --- > .../devicetree/bindings/arm64/xgene/reboot.txt | 10 ++ > 1 files changed, 10 insertions(+), 0 deletions(-) > create mode 100644

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-08 Thread Mark Rutland
On Tue, Jan 07, 2014 at 10:50:36PM +, Feng Kan wrote: Add X-Gene reboot device tree node documentation. Signed-off-by: Feng Kan f...@apm.com --- .../devicetree/bindings/arm64/xgene/reboot.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644

Re: [PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-08 Thread Arnd Bergmann
On Wednesday 08 January 2014 10:05:50 Mark Rutland wrote: + +Example: + + reboot@0 { + compatible = apm,xgene-reboot; + reg = 0x0 0x1714 0x0 0x4; + }; Given this seems to be a 64-bit address, the unit address should preferably be 0,1714

[PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-07 Thread Feng Kan
Add X-Gene reboot device tree node documentation. Signed-off-by: Feng Kan --- .../devicetree/bindings/arm64/xgene/reboot.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm64/xgene/reboot.txt diff --git

[PATCH V2 1/6] Documentation: add dts binding for X-Gene reboot dts node.

2014-01-07 Thread Feng Kan
Add X-Gene reboot device tree node documentation. Signed-off-by: Feng Kan f...@apm.com --- .../devicetree/bindings/arm64/xgene/reboot.txt | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/arm64/xgene/reboot.txt diff