Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-17 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 10:12, Anson Huang wrote: [ ... ] Please convert to timer-of API. >>> >>> This patch mainly to fix the potential resource leak issue, for >>> converting to timer-of API, should I add another patch for it? Since >>> it is a different subject. >> >> Actually I was

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-17 Thread Daniel Lezcano
Hi Anson, On 06/11/2018 10:12, Anson Huang wrote: [ ... ] Please convert to timer-of API. >>> >>> This patch mainly to fix the potential resource leak issue, for >>> converting to timer-of API, should I add another patch for it? Since >>> it is a different subject. >> >> Actually I was

RE: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-06 Thread Anson Huang
l Lezcano [mailto:daniel.lezc...@linaro.org] > >> Sent: 2018年11月5日 21:35 > >> To: Anson Huang ; t...@linutronix.de; > >> linux-kernel@vger.kernel.org > >> Cc: dl-linux-imx > >> Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree > >&g

RE: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-06 Thread Anson Huang
l Lezcano [mailto:daniel.lezc...@linaro.org] > >> Sent: 2018年11月5日 21:35 > >> To: Anson Huang ; t...@linutronix.de; > >> linux-kernel@vger.kernel.org > >> Cc: dl-linux-imx > >> Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree > >&g

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-06 Thread Daniel Lezcano
; >> linux-kernel@vger.kernel.org >> Cc: dl-linux-imx >> Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to >> avoid >> resource leak >> >> Hi Anson, >> >> On 05/11/2018 02:10, Anson Huang wrote: >>> k

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-06 Thread Daniel Lezcano
; >> linux-kernel@vger.kernel.org >> Cc: dl-linux-imx >> Subject: Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to >> avoid >> resource leak >> >> Hi Anson, >> >> On 05/11/2018 02:10, Anson Huang wrote: >>> k

RE: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-05 Thread Anson Huang
Hi, Daniel Best Regards! Anson Huang > -Original Message- > From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] > Sent: 2018年11月5日 21:35 > To: Anson Huang ; t...@linutronix.de; > linux-kernel@vger.kernel.org > Cc: dl-linux-imx > Subject: Re: [PATCH V2 2/2] cloc

RE: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-05 Thread Anson Huang
Hi, Daniel Best Regards! Anson Huang > -Original Message- > From: Daniel Lezcano [mailto:daniel.lezc...@linaro.org] > Sent: 2018年11月5日 21:35 > To: Anson Huang ; t...@linutronix.de; > linux-kernel@vger.kernel.org > Cc: dl-linux-imx > Subject: Re: [PATCH V2 2/2] cloc

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-05 Thread Daniel Lezcano
Hi Anson, On 05/11/2018 02:10, Anson Huang wrote: > kfree should be called to free resource in error path > before return. > > Signed-off-by: Anson Huang > --- > drivers/clocksource/timer-imx-gpt.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

Re: [PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-05 Thread Daniel Lezcano
Hi Anson, On 05/11/2018 02:10, Anson Huang wrote: > kfree should be called to free resource in error path > before return. > > Signed-off-by: Anson Huang > --- > drivers/clocksource/timer-imx-gpt.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git

[PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-04 Thread Anson Huang
kfree should be called to free resource in error path before return. Signed-off-by: Anson Huang --- drivers/clocksource/timer-imx-gpt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c index

[PATCH V2 2/2] clocksource: imx-gpt: add necessary kfree to avoid resource leak

2018-11-04 Thread Anson Huang
kfree should be called to free resource in error path before return. Signed-off-by: Anson Huang --- drivers/clocksource/timer-imx-gpt.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/timer-imx-gpt.c b/drivers/clocksource/timer-imx-gpt.c index