Re: [PATCH V2 2/9] cpufreq: conservative: remove 'enable' field

2015-09-07 Thread Viresh Kumar
On 08-09-15, 02:17, Rafael J. Wysocki wrote: > > static inline unsigned int get_freq_target(struct cs_dbs_tuners *cs_tuners, > >struct cpufreq_policy *policy) > > { > > @@ -119,12 +132,14 @@ static int dbs_cpufreq_notifier(struct notifier_block > > *nb,

Re: [PATCH V2 2/9] cpufreq: conservative: remove 'enable' field

2015-09-07 Thread Rafael J. Wysocki
On Monday, July 27, 2015 05:58:07 PM Viresh Kumar wrote: > Conservative governor has its own 'enable' field to check if > conservative governor is used for a CPU or not > > This can be checked by policy->governor with 'cpufreq_gov_conservative' > and so this field can be dropped. > > Because its

Re: [PATCH V2 2/9] cpufreq: conservative: remove 'enable' field

2015-09-07 Thread Viresh Kumar
On 08-09-15, 02:17, Rafael J. Wysocki wrote: > > static inline unsigned int get_freq_target(struct cs_dbs_tuners *cs_tuners, > >struct cpufreq_policy *policy) > > { > > @@ -119,12 +132,14 @@ static int dbs_cpufreq_notifier(struct notifier_block > > *nb,

Re: [PATCH V2 2/9] cpufreq: conservative: remove 'enable' field

2015-09-07 Thread Rafael J. Wysocki
On Monday, July 27, 2015 05:58:07 PM Viresh Kumar wrote: > Conservative governor has its own 'enable' field to check if > conservative governor is used for a CPU or not > > This can be checked by policy->governor with 'cpufreq_gov_conservative' > and so this field can be dropped. > > Because its

[PATCH V2 2/9] cpufreq: conservative: remove 'enable' field

2015-07-27 Thread Viresh Kumar
Conservative governor has its own 'enable' field to check if conservative governor is used for a CPU or not This can be checked by policy->governor with 'cpufreq_gov_conservative' and so this field can be dropped. Because its not guaranteed that dbs_info->cdbs.shared will a valid pointer for all

[PATCH V2 2/9] cpufreq: conservative: remove 'enable' field

2015-07-27 Thread Viresh Kumar
Conservative governor has its own 'enable' field to check if conservative governor is used for a CPU or not This can be checked by policy-governor with 'cpufreq_gov_conservative' and so this field can be dropped. Because its not guaranteed that dbs_info-cdbs.shared will a valid pointer for all