Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-20 Thread Stefan Wahren
Hi Fabio, > Stefan Wahren hat am 11. Februar 2015 um 21:31 > geschrieben: > > > Hi Fabio, > > > Fabio Estevam hat am 11. Februar 2015 um 17:58 > > geschrieben: > > > > > > Hi Stefan, > > > > On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren > > wrote: > > > Hi Fabio, > > > > > >> Fabio Estevam

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-20 Thread Stefan Wahren
Hi Fabio, Stefan Wahren stefan.wah...@i2se.com hat am 11. Februar 2015 um 21:31 geschrieben: Hi Fabio, Fabio Estevam feste...@gmail.com hat am 11. Februar 2015 um 17:58 geschrieben: Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren stefan.wah...@i2se.com wrote: Hi

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-17 Thread Marek Vasut
On Monday, February 16, 2015 at 09:24:51 PM, Stefan Wahren wrote: > Hi Fabio, > > > Fabio Estevam hat am 12. Februar 2015 um 20:08 > > geschrieben: > > > > > > Hi Stefan, > > > > On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren wrote: > > > Hi Fabio, > > > > > >> Fabio Estevam hat am 11.

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-17 Thread Marek Vasut
On Monday, February 16, 2015 at 09:24:51 PM, Stefan Wahren wrote: Hi Fabio, Fabio Estevam feste...@gmail.com hat am 12. Februar 2015 um 20:08 geschrieben: Hi Stefan, On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren stefan.wah...@i2se.com wrote: Hi Fabio, Fabio Estevam

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-16 Thread Stefan Wahren
Hi Fabio, > Fabio Estevam hat am 12. Februar 2015 um 20:08 > geschrieben: > > > Hi Stefan, > > On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren wrote: > > Hi Fabio, > > > >> Fabio Estevam hat am 11. Februar 2015 um 22:10 > >> geschrieben: > >> > >> > >> On Wed, Feb 11, 2015 at 6:31 PM, Stefan

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-16 Thread Stefan Wahren
Hi Fabio, Fabio Estevam feste...@gmail.com hat am 12. Februar 2015 um 20:08 geschrieben: Hi Stefan, On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren stefan.wah...@i2se.com wrote: Hi Fabio, Fabio Estevam feste...@gmail.com hat am 11. Februar 2015 um 22:10 geschrieben: On Wed,

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-12 Thread Fabio Estevam
Hi Stefan, On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren wrote: > Hi Fabio, > >> Fabio Estevam hat am 11. Februar 2015 um 22:10 >> geschrieben: >> >> >> On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren >> wrote: >> >> >> I always get 0x5e5b5513 with or without your patch. >> > >> > very

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-12 Thread Stefan Wahren
Hi Fabio, > Fabio Estevam hat am 11. Februar 2015 um 22:10 > geschrieben: > > > On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren wrote: > > >> I always get 0x5e5b5513 with or without your patch. > > > > very strange. Do you have any idea why IO1_STABLE is permanent low? > > On my case it is

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-12 Thread Stefan Wahren
Hi Fabio, Fabio Estevam feste...@gmail.com hat am 11. Februar 2015 um 22:10 geschrieben: On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren stefan.wah...@i2se.com wrote: I always get 0x5e5b5513 with or without your patch. very strange. Do you have any idea why IO1_STABLE is permanent low?

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-12 Thread Fabio Estevam
Hi Stefan, On Thu, Feb 12, 2015 at 4:59 PM, Stefan Wahren stefan.wah...@i2se.com wrote: Hi Fabio, Fabio Estevam feste...@gmail.com hat am 11. Februar 2015 um 22:10 geschrieben: On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren stefan.wah...@i2se.com wrote: I always get 0x5e5b5513 with or

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-11 Thread Fabio Estevam
On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren wrote: >> I always get 0x5e5b5513 with or without your patch. > > very strange. Do you have any idea why IO1_STABLE is permanent low? On my case it is always 1. > Can you confirm the behavior according to your flash issue? In my tests IO1_STABLE

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-11 Thread Stefan Wahren
Hi Fabio, > Fabio Estevam hat am 11. Februar 2015 um 17:58 > geschrieben: > > > Hi Stefan, > > On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren wrote: > > Hi Fabio, > > > >> Fabio Estevam hat am 10. Februar 2015 um 16:06 > >> geschrieben: > >> > >> > >> Hi Stefan, > >> > >> On Tue, Feb 10, 2015

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-11 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren wrote: > Hi Fabio, > >> Fabio Estevam hat am 10. Februar 2015 um 16:06 >> geschrieben: >> >> >> Hi Stefan, >> >> On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren >> wrote: >> >> > Could you apply only the clk-imx28.c part of my patch and

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-11 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren stefan.wah...@i2se.com wrote: Hi Fabio, Fabio Estevam feste...@gmail.com hat am 10. Februar 2015 um 16:06 geschrieben: Hi Stefan, On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren stefan.wah...@i2se.com wrote: Could you apply

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-11 Thread Stefan Wahren
Hi Fabio, Fabio Estevam feste...@gmail.com hat am 11. Februar 2015 um 17:58 geschrieben: Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren stefan.wah...@i2se.com wrote: Hi Fabio, Fabio Estevam feste...@gmail.com hat am 10. Februar 2015 um 16:06 geschrieben: Hi Stefan,

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-11 Thread Fabio Estevam
On Wed, Feb 11, 2015 at 6:31 PM, Stefan Wahren stefan.wah...@i2se.com wrote: I always get 0x5e5b5513 with or without your patch. very strange. Do you have any idea why IO1_STABLE is permanent low? On my case it is always 1. Can you confirm the behavior according to your flash issue? In my

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Mike Turquette
Quoting Marek Vasut (2015-02-10 14:07:51) > On Tuesday, February 10, 2015 at 10:54:52 PM, Fabio Estevam wrote: > > Hi Stefan, > > > > On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren > > wrote: > > > thanks this is very helpful. I built the linux-next for my Duckbill and > > > add the SSP2

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Marek Vasut
On Tuesday, February 10, 2015 at 10:54:52 PM, Fabio Estevam wrote: > Hi Stefan, > > On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren wrote: > > thanks this is very helpful. I built the linux-next for my Duckbill and > > add the SSP2 section from imx28-evk.dts into imx28-duckbill.dts. > > > >

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren wrote: > thanks this is very helpful. I built the linux-next for my Duckbill and add > the > SSP2 section from imx28-evk.dts into imx28-duckbill.dts. > > Without my patch i get the following for HW_CLKCTRL_FRAC0: > > ./memwatch -a

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Stefan Wahren
Hi Fabio, > Fabio Estevam hat am 10. Februar 2015 um 16:06 > geschrieben: > > > Hi Stefan, > > On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren > wrote: > > > Could you apply only the clk-imx28.c part of my patch and see what happens? > > If I apply only the clk-imx28.c part of your patch I can

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren wrote: > Could you apply only the clk-imx28.c part of my patch and see what happens? If I apply only the clk-imx28.c part of your patch I can successfully probe the SPI NOR. Thanks -- To unsubscribe from this list: send the line

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Stefan Wahren
Hi Fabio, Am 10.02.2015 um 14:09 schrieb Fabio Estevam: > Hi Stefan, > > On Tue, Feb 10, 2015 at 11:05 AM, Stefan Wahren > wrote: > >> sorry no. But i will try to get a mx28evk to reproduce the problem and > Just a comment: mx28evk comes without SPI NOR flash from the factory. > I have

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 11:05 AM, Stefan Wahren wrote: > sorry no. But i will try to get a mx28evk to reproduce the problem and Just a comment: mx28evk comes without SPI NOR flash from the factory. I have populated one in my mx28evk (slot U49). > narrow down which part of the patch

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Stefan Wahren
Hi Fabio, Am 10.02.2015 um 13:52 schrieb Fabio Estevam: > Hi Stefan, > > On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren wrote: >> According to i.MX23 and i.MX28 reference manual [1],[2] the fractional >> clock control register is 32-bit wide, but is separated in 4 parts. >> So write instructions

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren wrote: > According to i.MX23 and i.MX28 reference manual [1],[2] the fractional > clock control register is 32-bit wide, but is separated in 4 parts. > So write instructions must not apply to more than 1 part at once. > > The clk init for

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Mike Turquette
Quoting Marek Vasut (2015-02-10 14:07:51) On Tuesday, February 10, 2015 at 10:54:52 PM, Fabio Estevam wrote: Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren stefan.wah...@i2se.com wrote: thanks this is very helpful. I built the linux-next for my Duckbill and add the SSP2

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Stefan Wahren
Hi Fabio, Am 10.02.2015 um 14:09 schrieb Fabio Estevam: Hi Stefan, On Tue, Feb 10, 2015 at 11:05 AM, Stefan Wahren stefan.wah...@i2se.com wrote: sorry no. But i will try to get a mx28evk to reproduce the problem and Just a comment: mx28evk comes without SPI NOR flash from the factory. I

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren stefan.wah...@i2se.com wrote: thanks this is very helpful. I built the linux-next for my Duckbill and add the SSP2 section from imx28-evk.dts into imx28-duckbill.dts. Without my patch i get the following for HW_CLKCTRL_FRAC0:

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Stefan Wahren
Hi Fabio, Fabio Estevam feste...@gmail.com hat am 10. Februar 2015 um 16:06 geschrieben: Hi Stefan, On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren stefan.wah...@i2se.com wrote: Could you apply only the clk-imx28.c part of my patch and see what happens? If I apply only the

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Marek Vasut
On Tuesday, February 10, 2015 at 10:54:52 PM, Fabio Estevam wrote: Hi Stefan, On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren stefan.wah...@i2se.com wrote: thanks this is very helpful. I built the linux-next for my Duckbill and add the SSP2 section from imx28-evk.dts into

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren stefan.wah...@i2se.com wrote: Could you apply only the clk-imx28.c part of my patch and see what happens? If I apply only the clk-imx28.c part of your patch I can successfully probe the SPI NOR. Thanks -- To unsubscribe from this

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Stefan Wahren
Hi Fabio, Am 10.02.2015 um 13:52 schrieb Fabio Estevam: Hi Stefan, On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren stefan.wah...@i2se.com wrote: According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Tue, Feb 10, 2015 at 11:05 AM, Stefan Wahren stefan.wah...@i2se.com wrote: sorry no. But i will try to get a mx28evk to reproduce the problem and Just a comment: mx28evk comes without SPI NOR flash from the factory. I have populated one in my mx28evk (slot U49). narrow down

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-10 Thread Fabio Estevam
Hi Stefan, On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren stefan.wah...@i2se.com wrote: According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write instructions must not apply to more than 1 part at once.

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-03 Thread Mike Turquette
Quoting Fabio Estevam (2015-01-30 11:28:32) > On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren wrote: > > According to i.MX23 and i.MX28 reference manual [1],[2] the fractional > > clock control register is 32-bit wide, but is separated in 4 parts. > > So write instructions must not apply to more

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-02-03 Thread Mike Turquette
Quoting Fabio Estevam (2015-01-30 11:28:32) On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren stefan.wah...@i2se.com wrote: According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write instructions must not

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-30 Thread Fabio Estevam
On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren wrote: > According to i.MX23 and i.MX28 reference manual [1],[2] the fractional > clock control register is 32-bit wide, but is separated in 4 parts. > So write instructions must not apply to more than 1 part at once. > > The clk init for the i.MX28

[PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-30 Thread Stefan Wahren
According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write instructions must not apply to more than 1 part at once. The clk init for the i.MX28 violates this restriction and all the other accesses on that

[PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-30 Thread Stefan Wahren
According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write instructions must not apply to more than 1 part at once. The clk init for the i.MX28 violates this restriction and all the other accesses on that

[PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-30 Thread Stefan Wahren
According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write instructions must not apply to more than 1 part at once. The clk init for the i.MX28 violates this restriction and all the other accesses on that

Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-30 Thread Fabio Estevam
On Fri, Jan 30, 2015 at 5:20 PM, Stefan Wahren stefan.wah...@i2se.com wrote: According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write instructions must not apply to more than 1 part at once. The clk

[PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers

2015-01-30 Thread Stefan Wahren
According to i.MX23 and i.MX28 reference manual [1],[2] the fractional clock control register is 32-bit wide, but is separated in 4 parts. So write instructions must not apply to more than 1 part at once. The clk init for the i.MX28 violates this restriction and all the other accesses on that