Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-06 Thread Rafał Miłecki
On 2021-03-06 09:00, Thomas Bogendoerfer wrote: On Fri, Mar 05, 2021 at 12:56:55PM +0100, Rafał Miłecki wrote: On 05.03.2021 12:47, Philippe Mathieu-Daudé wrote: > On Fri, Mar 5, 2021 at 11:16 AM Rafał Miłecki wrote: > > On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: > > > On Fri, Mar 5, 20

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-06 Thread Thomas Bogendoerfer
On Fri, Mar 05, 2021 at 12:56:55PM +0100, Rafał Miłecki wrote: > On 05.03.2021 12:47, Philippe Mathieu-Daudé wrote: > > On Fri, Mar 5, 2021 at 11:16 AM Rafał Miłecki wrote: > > > On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: > > > > On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: > > > >

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-05 Thread Rafał Miłecki
On 05.03.2021 12:47, Philippe Mathieu-Daudé wrote: On Fri, Mar 5, 2021 at 11:16 AM Rafał Miłecki wrote: On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: From: Rafał Miłecki 1. Use meaningful variable names (e.g. "flash_start", "res_siz

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-05 Thread Philippe Mathieu-Daudé
On Fri, Mar 5, 2021 at 11:16 AM Rafał Miłecki wrote: > > Hi, > > On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: > > On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: > >> > >> From: Rafał Miłecki > >> > >> 1. Use meaningful variable names (e.g. "flash_start", "res_size" instead > >> of

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-05 Thread Rafał Miłecki
Hi, On 05.03.2021 10:58, Philippe Mathieu-Daudé wrote: On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: From: Rafał Miłecki 1. Use meaningful variable names (e.g. "flash_start", "res_size" instead of e.g. "iobase", "end") 2. Always operate on "offset" instead of mix of start, end, si

Re: [PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-05 Thread Philippe Mathieu-Daudé
Hi Rafał, On Fri, Mar 5, 2021 at 6:55 AM Rafał Miłecki wrote: > > From: Rafał Miłecki > > 1. Use meaningful variable names (e.g. "flash_start", "res_size" instead >of e.g. "iobase", "end") > 2. Always operate on "offset" instead of mix of start, end, size, etc. "instead of a mix" > 3. Add

[PATCH V2 mips/linux.git] firmware: bcm47xx_nvram: refactor finding & reading NVRAM

2021-03-04 Thread Rafał Miłecki
From: Rafał Miłecki 1. Use meaningful variable names (e.g. "flash_start", "res_size" instead of e.g. "iobase", "end") 2. Always operate on "offset" instead of mix of start, end, size, etc. 3. Add helper checking for NVRAM to avoid duplicating code 4. Use "found" variable instead of goto 5. Use