Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

OK, we will use module_pci_driver although it is not very common in the same segment. On 7/25/2017 11:02 PM, Francois Romieu wrote: > Aviad Krawczyk : > [...] >> module_pci_driver - is not used in other drivers in the same segments, it >> is necessary ? > > /me

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

OK, we will use module_pci_driver although it is not very common in the same segment. On 7/25/2017 11:02 PM, Francois Romieu wrote: > Aviad Krawczyk : > [...] >> module_pci_driver - is not used in other drivers in the same segments, it >> is necessary ? > > /me checks... Ok, there seems to be

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > module_pci_driver - is not used in other drivers in the same segments, it > is necessary ? /me checks... Ok, there seems to be some overenthusiastic copy'paste. See drivers/net/ethernet/intel/ixgb/ixgb_main.c: [...] /** * ixgb_init_module -

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > module_pci_driver - is not used in other drivers in the same segments, it > is necessary ? /me checks... Ok, there seems to be some overenthusiastic copy'paste. See drivers/net/ethernet/intel/ixgb/ixgb_main.c: [...] /** * ixgb_init_module - Driver Registration Routine

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Hi, hinic_remove - you are right, it is over safe code. We can remove it without any crash. This case has never happened. void * - I meant the problem is not in rq or sq, it can be in wq. But you confirmed that it is ok to use union instead of the void* in wq. So, we will use union in wq.c and

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Hi, hinic_remove - you are right, it is over safe code. We can remove it without any crash. This case has never happened. void * - I meant the problem is not in rq or sq, it can be in wq. But you confirmed that it is ok to use union instead of the void* in wq. So, we will use union in wq.c and

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > hinic_remove - If insmod failed and someone calls rmmod, we will get a > crash because the resource are already free. Therefore we test if the > device exists, please tell me if you meant to something different The module won't even proceed

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > hinic_remove - If insmod failed and someone calls rmmod, we will get a > crash because the resource are already free. Therefore we test if the > device exists, please tell me if you meant to something different The module won't even proceed through the pci_driver remove

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Hi Francois, ERR_PTR / IS ERR - we will change it err_xyz labels - we will change it according to other companies style. hinic_free_hwdev - It is there to mark us changes for VF code. We will remove it, it can't be failed. hinic_remove - If insmod failed and someone calls rmmod, we will get a

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Hi Francois, ERR_PTR / IS ERR - we will change it err_xyz labels - we will change it according to other companies style. hinic_free_hwdev - It is there to mark us changes for VF code. We will remove it, it can't be failed. hinic_remove - If insmod failed and someone calls rmmod, we will get a

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > new file mode 100644 > index 000..fbc9de4 > --- /dev/null > +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c [...] >

Re: [PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Aviad Krawczyk : [...] > diff --git a/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c > new file mode 100644 > index 000..fbc9de4 > --- /dev/null > +++ b/drivers/net/ethernet/huawei/hinic/hinic_hw_dev.c [...] > +/** > + * hinic_init_hwdev

[PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Initialize hw interface as part of the nic initialization for accessing hw. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- Documentation/networking/hinic.txt | 125 drivers/net/ethernet/Kconfig

[PATCH V2 net-next 01/21] net-next/hinic: Initialize hw interface

Initialize hw interface as part of the nic initialization for accessing hw. Signed-off-by: Aviad Krawczyk Signed-off-by: Zhao Chen --- Documentation/networking/hinic.txt | 125 drivers/net/ethernet/Kconfig | 1 +