Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:18 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-05 Thread Netanel Belgazal
On 12/05/2016 06:18 AM, Matt Wilson wrote: On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-04 Thread Matt Wilson
On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: > ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type > treat the ena_flow_hash_to_flow_type enum as power of two values. > > Change the values of ena_admin_flow_hash_fields to be power of two values. Then I generally prefer

Re: [PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-04 Thread Matt Wilson
On Sun, Dec 04, 2016 at 03:19:22PM +0200, Netanel Belgazal wrote: > ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type > treat the ena_flow_hash_to_flow_type enum as power of two values. > > Change the values of ena_admin_flow_hash_fields to be power of two values. Then I generally prefer

[PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-04 Thread Netanel Belgazal
ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power of two values. Signed-off-by: Netanel Belgazal ---

[PATCH V2 net 04/20] net/ena: fix ethtool RSS flow configuration

2016-12-04 Thread Netanel Belgazal
ena_flow_data_to_flow_hash and ena_flow_hash_to_flow_type treat the ena_flow_hash_to_flow_type enum as power of two values. Change the values of ena_admin_flow_hash_fields to be power of two values. Signed-off-by: Netanel Belgazal --- drivers/net/ethernet/amazon/ena/ena_admin_defs.h | 12