Re: [PATCH V3] mfd: wm8994-core: Don't use managed regulator bulk get API

2016-10-27 Thread Viresh Kumar
On 27-10-16, 10:14, Charles Keepax wrote: > On Thu, Oct 27, 2016 at 09:09:30AM +0530, Viresh Kumar wrote: > > The kernel WARNs and then crashes today if wm8994_device_init() fails > > after calling devm_regulator_bulk_get(). > > > > That happens because there are multiple devices involved here and

Re: [PATCH V3] mfd: wm8994-core: Don't use managed regulator bulk get API

2016-10-27 Thread Charles Keepax
On Thu, Oct 27, 2016 at 09:09:30AM +0530, Viresh Kumar wrote: > The kernel WARNs and then crashes today if wm8994_device_init() fails > after calling devm_regulator_bulk_get(). > > That happens because there are multiple devices involved here and the > order in which resources are freed isn't corr

[PATCH V3] mfd: wm8994-core: Don't use managed regulator bulk get API

2016-10-26 Thread Viresh Kumar
The kernel WARNs and then crashes today if wm8994_device_init() fails after calling devm_regulator_bulk_get(). That happens because there are multiple devices involved here and the order in which resources are freed isn't correct. The regulators are added as children of wm8994->dev. devm_regulato