On 2018-09-10 16:56, Mark Brown wrote:
On Mon, Sep 10, 2018 at 09:27:09AM +0530, dk...@codeaurora.org wrote:
> The thing is, we want it to be 100% reliable, not 99.9% reliable. Is
> it somehow wrong to add the spinlock? ...or are you noticing
> performance problems with the spinlock there? I
On Mon, Sep 10, 2018 at 09:27:09AM +0530, dk...@codeaurora.org wrote:
> > The thing is, we want it to be 100% reliable, not 99.9% reliable. Is
> > it somehow wrong to add the spinlock? ...or are you noticing
> > performance problems with the spinlock there? It's just nice not to
> > have to thi
I see there is no need of taking the spinlock as timeout will be
handled
after the calculated time as per data size and speed.
There is 99.9% less chances of interrupt during the timeout handler.
https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1201081
The thing
Hi,
On Fri, Sep 7, 2018 at 3:00 AM, wrote:
>> In v2, I said:
>>
>>> I'm not sure where to comment about this, so adding it to the end:
>>>
>>> Between v1 and v2 you totally removed all the locking. Presumably
>>> this is because you didn't want to hold the lock in
>>> handle_fifo_timeout() whil
Hi,
On Fri, Sep 7, 2018 at 3:00 AM, wrote:
>> In v2, I said:
>>
>>> I'm not sure where to comment about this, so adding it to the end:
>>>
>>> Between v1 and v2 you totally removed all the locking. Presumably
>>> this is because you didn't want to hold the lock in
>>> handle_fifo_timeout() whil
When spi_alloc_master() fails you don't want spi_master_put().
Agree, will update it.
--Dilip
On 2018-09-02 10:36, Doug Anderson wrote:
Hi,
On Fri, Aug 24, 2018 at 3:42 AM, Dilip Kota
wrote:
From: Girish Mahadevan
This driver supports GENI based SPI Controller in the Qualcomm SOCs.
The
Qualcomm Generic Interface (GENI) is a programmable module supporting
a
wide range of serial int
Hi,
On Fri, Aug 24, 2018 at 3:42 AM, Dilip Kota wrote:
> From: Girish Mahadevan
>
> This driver supports GENI based SPI Controller in the Qualcomm SOCs. The
> Qualcomm Generic Interface (GENI) is a programmable module supporting a
> wide range of serial interfaces including SPI. This driver supp
Quoting Dilip Kota (2018-08-24 03:42:15)
> +
> +static int __maybe_unused spi_geni_suspend(struct device *dev)
> +{
> + if (!pm_runtime_status_suspended(dev))
> + return -EBUSY;
This looks odd. Why are we doing this? The i2c driver had a recent fix
from Evan squashed in that re
On Wed, Aug 29, 2018 at 6:19 AM wrote:
>
> On 2018-08-29 05:55, Rob Herring wrote:
> > On Fri, Aug 24, 2018 at 04:12:15PM +0530, Dilip Kota wrote:
> >> From: Girish Mahadevan
> >>
> >> This driver supports GENI based SPI Controller in the Qualcomm SOCs.
> >> The
> >> Qualcomm Generic Interface (G
On 2018-08-29 05:55, Rob Herring wrote:
On Fri, Aug 24, 2018 at 04:12:15PM +0530, Dilip Kota wrote:
From: Girish Mahadevan
This driver supports GENI based SPI Controller in the Qualcomm SOCs.
The
Qualcomm Generic Interface (GENI) is a programmable module supporting
a
wide range of serial int
On Fri, Aug 24, 2018 at 04:12:15PM +0530, Dilip Kota wrote:
> From: Girish Mahadevan
>
> This driver supports GENI based SPI Controller in the Qualcomm SOCs. The
> Qualcomm Generic Interface (GENI) is a programmable module supporting a
> wide range of serial interfaces including SPI. This driver
Hi Girish,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on spi/for-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Dilip-Kota/spi-spi-geni-qcom-Add-SPI-driver-
Hi Girish,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on spi/for-next]
[also build test ERROR on v4.18]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Dilip-Kota/
From: Girish Mahadevan
This driver supports GENI based SPI Controller in the Qualcomm SOCs. The
Qualcomm Generic Interface (GENI) is a programmable module supporting a
wide range of serial interfaces including SPI. This driver supports SPI
operations using FIFO mode of transfer.
Signed-off-by: G
15 matches
Mail list logo
