Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-11 Thread James Morris
On Fri, 7 Sep 2012, Kent Yoder wrote: > > > James did accept my pull request, so these are already in > > > security-next... > > > > For the driver itself, it's not a big issue (though I did found issue > > while reviewing it so it will need another round of updates). For the > > code that

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-11 Thread James Morris
On Fri, 7 Sep 2012, Kent Yoder wrote: James did accept my pull request, so these are already in security-next... For the driver itself, it's not a big issue (though I did found issue while reviewing it so it will need another round of updates). For the code that changes

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-07 Thread Kent Yoder
> > James did accept my pull request, so these are already in > > security-next... > > For the driver itself, it's not a big issue (though I did found issue > while reviewing it so it will need another round of updates). For the > code that changes arch/powerpc, especially prom_init.c, that

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-07 Thread Kent Yoder
James did accept my pull request, so these are already in security-next... For the driver itself, it's not a big issue (though I did found issue while reviewing it so it will need another round of updates). For the code that changes arch/powerpc, especially prom_init.c, that stuff must

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-05 Thread Benjamin Herrenschmidt
On Wed, 2012-09-05 at 10:46 -0500, Kent Yoder wrote: > On Wed, Sep 05, 2012 at 01:40:07PM +1000, Benjamin Herrenschmidt wrote: > > On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote: > > > On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: > > > > This patch adds a new device driver to

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-05 Thread Ashley Lai
Hi Ben., Thank you so much for the comments. Please see my response below. > > > + */ > > > +static int tpm_ibmvtpm_recv(struct tpm_chip *chip, u8 *buf, size_t count) > > > +{ > > > + struct ibmvtpm_dev *ibmvtpm; > > > + u16 len; > > > + > > > + ibmvtpm = (struct ibmvtpm_dev

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-05 Thread Kent Yoder
On Wed, Sep 05, 2012 at 01:40:07PM +1000, Benjamin Herrenschmidt wrote: > On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote: > > On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: > > > This patch adds a new device driver to support IBM virtual TPM > > > (vTPM) for PPC64. IBM vTPM is

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-05 Thread Kent Yoder
On Wed, Sep 05, 2012 at 01:40:07PM +1000, Benjamin Herrenschmidt wrote: On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote: On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-05 Thread Ashley Lai
Hi Ben., Thank you so much for the comments. Please see my response below. + */ +static int tpm_ibmvtpm_recv(struct tpm_chip *chip, u8 *buf, size_t count) +{ + struct ibmvtpm_dev *ibmvtpm; + u16 len; + + ibmvtpm = (struct ibmvtpm_dev *)chip-vendor.data; + + if

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-05 Thread Benjamin Herrenschmidt
On Wed, 2012-09-05 at 10:46 -0500, Kent Yoder wrote: On Wed, Sep 05, 2012 at 01:40:07PM +1000, Benjamin Herrenschmidt wrote: On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote: On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: This patch adds a new device driver to support IBM

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-04 Thread Benjamin Herrenschmidt
On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote: > On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: > > This patch adds a new device driver to support IBM virtual TPM > > (vTPM) for PPC64. IBM vTPM is supported through the adjunct > > partition with firmware release 740 or higher.

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-09-04 Thread Benjamin Herrenschmidt
On Wed, 2012-08-22 at 16:42 -0500, Kent Yoder wrote: On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported through the adjunct partition with firmware release 740 or higher. With

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-08-22 Thread Kent Yoder
On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: > This patch adds a new device driver to support IBM virtual TPM > (vTPM) for PPC64. IBM vTPM is supported through the adjunct > partition with firmware release 740 or higher. With vTPM > support, each lpar is able to have its own vTPM

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-08-22 Thread Ashley Lai
This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported through the adjunct partition with firmware release 740 or higher. With vTPM support, each lpar is able to have its own vTPM without the physical TPM hardware. This driver provides TPM

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-08-22 Thread Ashley Lai
This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported through the adjunct partition with firmware release 740 or higher. With vTPM support, each lpar is able to have its own vTPM without the physical TPM hardware. This driver provides TPM

Re: [PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-08-22 Thread Kent Yoder
On Wed, Aug 22, 2012 at 04:17:43PM -0500, Ashley Lai wrote: This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported through the adjunct partition with firmware release 740 or higher. With vTPM support, each lpar is able to have its own vTPM

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-08-14 Thread Ashley Lai
This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported through the adjunct partition with firmware release 740 or higher. With vTPM support, each lpar is able to have its own vTPM without the physical TPM hardware. This driver provides TPM

[PATCH V3 1/3] drivers/char/tpm: Add new device driver to support IBM vTPM

2012-08-14 Thread Ashley Lai
This patch adds a new device driver to support IBM virtual TPM (vTPM) for PPC64. IBM vTPM is supported through the adjunct partition with firmware release 740 or higher. With vTPM support, each lpar is able to have its own vTPM without the physical TPM hardware. This driver provides TPM