Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-05 Thread Michal Hocko
On Sat 05-01-13 10:49:00, Sha Zhengju wrote: [...] > >> Here is some test numbers that before/after this patch: > >> Test steps(Mem-4g, ext4): > >> drop_cache; sync > >> fio > >> (ioengine=sync/write/buffered/bs=4k/size=1g/numjobs=2/group_reporting/thread) > > > > Could also add some rationale

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-05 Thread Michal Hocko
On Sat 05-01-13 10:49:00, Sha Zhengju wrote: [...] Here is some test numbers that before/after this patch: Test steps(Mem-4g, ext4): drop_cache; sync fio (ioengine=sync/write/buffered/bs=4k/size=1g/numjobs=2/group_reporting/thread) Could also add some rationale why you think this

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-04 Thread Sha Zhengju
Hi Michal, Sorry for my late response, I'm just back from vocation. : ) On Wed, Jan 2, 2013 at 5:08 PM, Michal Hocko wrote: > On Wed 26-12-12 01:22:36, Sha Zhengju wrote: >> From: Sha Zhengju >> >> Commit a8e7d49a(Fix race in create_empty_buffers() vs >> __set_page_dirty_buffers()) >>

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-04 Thread Sha Zhengju
Hi Kame, Sorry for the late response, I'm just back from vocation. : ) On Fri, Dec 28, 2012 at 8:39 AM, Kamezawa Hiroyuki wrote: > (2012/12/26 2:22), Sha Zhengju wrote: >> From: Sha Zhengju >> >> Commit a8e7d49a(Fix race in create_empty_buffers() vs >> __set_page_dirty_buffers()) >> extracts

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-04 Thread Sha Zhengju
Hi Kame, Sorry for the late response, I'm just back from vocation. : ) On Fri, Dec 28, 2012 at 8:39 AM, Kamezawa Hiroyuki kamezawa.hir...@jp.fujitsu.com wrote: (2012/12/26 2:22), Sha Zhengju wrote: From: Sha Zhengju handai@taobao.com Commit a8e7d49a(Fix race in create_empty_buffers() vs

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-04 Thread Sha Zhengju
Hi Michal, Sorry for my late response, I'm just back from vocation. : ) On Wed, Jan 2, 2013 at 5:08 PM, Michal Hocko mho...@suse.cz wrote: On Wed 26-12-12 01:22:36, Sha Zhengju wrote: From: Sha Zhengju handai@taobao.com Commit a8e7d49a(Fix race in create_empty_buffers() vs

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-02 Thread Michal Hocko
On Wed 26-12-12 01:22:36, Sha Zhengju wrote: > From: Sha Zhengju > > Commit a8e7d49a(Fix race in create_empty_buffers() vs > __set_page_dirty_buffers()) > extracts TestSetPageDirty from __set_page_dirty and is far away from > account_page_dirtied. But it's better to make the two operations in

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2013-01-02 Thread Michal Hocko
On Wed 26-12-12 01:22:36, Sha Zhengju wrote: From: Sha Zhengju handai@taobao.com Commit a8e7d49a(Fix race in create_empty_buffers() vs __set_page_dirty_buffers()) extracts TestSetPageDirty from __set_page_dirty and is far away from account_page_dirtied. But it's better to make the two

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2012-12-27 Thread Kamezawa Hiroyuki
(2012/12/26 2:22), Sha Zhengju wrote: > From: Sha Zhengju > > Commit a8e7d49a(Fix race in create_empty_buffers() vs > __set_page_dirty_buffers()) > extracts TestSetPageDirty from __set_page_dirty and is far away from > account_page_dirtied. But it's better to make the two operations in one

Re: [PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2012-12-27 Thread Kamezawa Hiroyuki
(2012/12/26 2:22), Sha Zhengju wrote: From: Sha Zhengju handai@taobao.com Commit a8e7d49a(Fix race in create_empty_buffers() vs __set_page_dirty_buffers()) extracts TestSetPageDirty from __set_page_dirty and is far away from account_page_dirtied. But it's better to make the two

[PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2012-12-25 Thread Sha Zhengju
From: Sha Zhengju Commit a8e7d49a(Fix race in create_empty_buffers() vs __set_page_dirty_buffers()) extracts TestSetPageDirty from __set_page_dirty and is far away from account_page_dirtied. But it's better to make the two operations in one single function to keep modular. So in order to avoid

[PATCH V3 2/8] Make TestSetPageDirty and dirty page accounting in one func

2012-12-25 Thread Sha Zhengju
From: Sha Zhengju handai@taobao.com Commit a8e7d49a(Fix race in create_empty_buffers() vs __set_page_dirty_buffers()) extracts TestSetPageDirty from __set_page_dirty and is far away from account_page_dirtied. But it's better to make the two operations in one single function to keep modular.