Re: [PATCH V3 3/3] phy: phy-brcm-usb: support PHY on the BCM4908

2021-01-06 Thread Florian Fainelli
On 1/6/21 5:22 AM, Rafał Miłecki wrote:
> From: Rafał Miłecki 
> 
> BCM4908 seems to have slightly different registers but works when
> programmed just like the STB one.
> 
> Signed-off-by: Rafał Miłecki 

Acked-by: Florian Fainelli 
-- 
Florian


[PATCH V3 3/3] phy: phy-brcm-usb: support PHY on the BCM4908

2021-01-06 Thread Rafał Miłecki
From: Rafał Miłecki 

BCM4908 seems to have slightly different registers but works when
programmed just like the STB one.

Signed-off-by: Rafał Miłecki 
---
V2: Update Kconfig as well
---
 drivers/phy/broadcom/Kconfig| 3 ++-
 drivers/phy/broadcom/phy-brcm-usb.c | 4 
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/phy/broadcom/Kconfig b/drivers/phy/broadcom/Kconfig
index a1f1a9c90d0d..09256339bd04 100644
--- a/drivers/phy/broadcom/Kconfig
+++ b/drivers/phy/broadcom/Kconfig
@@ -91,10 +91,11 @@ config PHY_BRCM_SATA
 
 config PHY_BRCM_USB
tristate "Broadcom STB USB PHY driver"
-   depends on ARCH_BRCMSTB || COMPILE_TEST
+   depends on ARCH_BCM4908 || ARCH_BRCMSTB || COMPILE_TEST
depends on OF
select GENERIC_PHY
select SOC_BRCMSTB
+   default ARCH_BCM4908
default ARCH_BRCMSTB
help
  Enable this to support the Broadcom STB USB PHY.
diff --git a/drivers/phy/broadcom/phy-brcm-usb.c 
b/drivers/phy/broadcom/phy-brcm-usb.c
index 99fbc7e4138b..63f922a5f29b 100644
--- a/drivers/phy/broadcom/phy-brcm-usb.c
+++ b/drivers/phy/broadcom/phy-brcm-usb.c
@@ -285,6 +285,10 @@ static const struct match_chip_info chip_info_7445 = {
 };
 
 static const struct of_device_id brcm_usb_dt_ids[] = {
+   {
+   .compatible = "brcm,bcm4908-usb-phy",
+   .data = _info_7445,
+   },
{
.compatible = "brcm,bcm7216-usb-phy",
.data = _info_7216,
-- 
2.26.2