Re: [PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision

2017-11-29 Thread Sinan Kaya
+linux-acpi On 11/29/2017 8:58 AM, Vinod Koul wrote: >> +cap = (enum hidma_cap) acpi_device_get_match_data(dev); > should this not reside in core? How about a device_get_match_data() which > returns the data for folks based on node being acpi/of Sure, I'm preparing a device function

Re: [PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision

2017-11-29 Thread Sinan Kaya
+linux-acpi On 11/29/2017 8:58 AM, Vinod Koul wrote: >> +cap = (enum hidma_cap) acpi_device_get_match_data(dev); > should this not reside in core? How about a device_get_match_data() which > returns the data for folks based on node being acpi/of Sure, I'm preparing a device function

Re: [PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision

2017-11-29 Thread Vinod Koul
On Thu, Nov 09, 2017 at 09:32:54PM -0500, Sinan Kaya wrote: > -static bool hidma_msi_capable(struct device *dev) > +static bool hidma_test_capability(struct device *dev, enum hidma_cap > test_cap) > { > struct acpi_device *adev = ACPI_COMPANION(dev); > - const char *of_compat; > -

Re: [PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision

2017-11-29 Thread Vinod Koul
On Thu, Nov 09, 2017 at 09:32:54PM -0500, Sinan Kaya wrote: > -static bool hidma_msi_capable(struct device *dev) > +static bool hidma_test_capability(struct device *dev, enum hidma_cap > test_cap) > { > struct acpi_device *adev = ACPI_COMPANION(dev); > - const char *of_compat; > -

[PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision

2017-11-09 Thread Sinan Kaya
Add support for probing the newer HW and also organize MSI capable hardware into an array for maintenance reasons. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git

[PATCH V3 3/4] dmaengine: qcom_hidma: add support for the new revision

2017-11-09 Thread Sinan Kaya
Add support for probing the newer HW and also organize MSI capable hardware into an array for maintenance reasons. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git