Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-24 Thread Shiraz Hashim
On Wed, Oct 24, 2012 at 07:51:37AM +0200, Thierry Reding wrote: > On Mon, Oct 22, 2012 at 04:36:41PM +0530, Shiraz Hashim wrote: > [...] > > +struct spear_pwm_chip { > > + void __iomem *mmio_base; > > + struct clk *clk; > > + struct pwm_chip chip; > > My editor shows a tab between pwm_chip

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-24 Thread Viresh Kumar
On 24 October 2012 11:21, Thierry Reding wrote: > On Mon, Oct 22, 2012 at 04:36:41PM +0530, Shiraz Hashim wrote: >> + ret = pwmchip_add(>chip); >> + if (ret < 0) { >> + dev_err(>dev, "pwmchip_add() failed: %d\n", ret); >> + return ret; >> + } >> + >> + ret

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-24 Thread Viresh Kumar
On 24 October 2012 11:21, Thierry Reding thierry.red...@avionic-design.de wrote: On Mon, Oct 22, 2012 at 04:36:41PM +0530, Shiraz Hashim wrote: + ret = pwmchip_add(pc-chip); + if (ret 0) { + dev_err(pdev-dev, pwmchip_add() failed: %d\n, ret); + return ret; +

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-24 Thread Shiraz Hashim
On Wed, Oct 24, 2012 at 07:51:37AM +0200, Thierry Reding wrote: On Mon, Oct 22, 2012 at 04:36:41PM +0530, Shiraz Hashim wrote: [...] +struct spear_pwm_chip { + void __iomem *mmio_base; + struct clk *clk; + struct pwm_chip chip; My editor shows a tab between pwm_chip and chip.

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-23 Thread Thierry Reding
On Mon, Oct 22, 2012 at 04:36:41PM +0530, Shiraz Hashim wrote: [...] > +struct spear_pwm_chip { > + void __iomem *mmio_base; > + struct clk *clk; > + struct pwm_chip chip; My editor shows a tab between pwm_chip and chip. This should really be a space. > + ret =

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-23 Thread Thierry Reding
On Mon, Oct 22, 2012 at 07:25:45PM +0530, Viresh Kumar wrote: > On 22 October 2012 16:36, Shiraz Hashim wrote: > > Add support for PWM chips present on SPEAr platforms. These PWM > > chips support 4 channel output with programmable duty cycle and > > frequency. > > > > More details on these PWM

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-23 Thread Thierry Reding
On Mon, Oct 22, 2012 at 07:25:45PM +0530, Viresh Kumar wrote: On 22 October 2012 16:36, Shiraz Hashim shiraz.has...@st.com wrote: Add support for PWM chips present on SPEAr platforms. These PWM chips support 4 channel output with programmable duty cycle and frequency. More details on

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-23 Thread Thierry Reding
On Mon, Oct 22, 2012 at 04:36:41PM +0530, Shiraz Hashim wrote: [...] +struct spear_pwm_chip { + void __iomem *mmio_base; + struct clk *clk; + struct pwm_chip chip; My editor shows a tab between pwm_chip and chip. This should really be a space. + ret = pwmchip_add(pc-chip);

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-22 Thread Viresh Kumar
On 22 October 2012 16:36, Shiraz Hashim wrote: > Add support for PWM chips present on SPEAr platforms. These PWM > chips support 4 channel output with programmable duty cycle and > frequency. > > More details on these PWM chips can be obtained from relevant > chapter of reference manual, present

[PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-22 Thread Shiraz Hashim
Add support for PWM chips present on SPEAr platforms. These PWM chips support 4 channel output with programmable duty cycle and frequency. More details on these PWM chips can be obtained from relevant chapter of reference manual, present at following[1] location. 1.

[PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-22 Thread Shiraz Hashim
Add support for PWM chips present on SPEAr platforms. These PWM chips support 4 channel output with programmable duty cycle and frequency. More details on these PWM chips can be obtained from relevant chapter of reference manual, present at following[1] location. 1.

Re: [PATCH V4] PWM: Add SPEAr PWM chip driver support

2012-10-22 Thread Viresh Kumar
On 22 October 2012 16:36, Shiraz Hashim shiraz.has...@st.com wrote: Add support for PWM chips present on SPEAr platforms. These PWM chips support 4 channel output with programmable duty cycle and frequency. More details on these PWM chips can be obtained from relevant chapter of reference