Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 07:17:41 -0500 > Then hard code the domain number as 0 while calling > pci_get_domain_bus_and_slot() if you know for sure that this device > will never work on a non-zero domain. Agreed, it's so much better to be explicit about this.

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 07:17:41 -0500 > Then hard code the domain number as 0 while calling > pci_get_domain_bus_and_slot() if you know for sure that this device > will never work on a non-zero domain. Agreed, it's so much better to be explicit about this.

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 00:37:50 -0500 > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread David Miller
From: Sinan Kaya Date: Tue, 19 Dec 2017 00:37:50 -0500 > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread Andy Shevchenko
On Tue, 2017-12-19 at 07:17 -0500, Sinan Kaya wrote: > On 12/19/2017 5:45 AM, Andy Shevchenko wrote: > > On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote: > > > > > pci_get_bus_and_slot() still might be useful for the wired devices > > in > > SoC where we know for sure that domain == 0. > >

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread Andy Shevchenko
On Tue, 2017-12-19 at 07:17 -0500, Sinan Kaya wrote: > On 12/19/2017 5:45 AM, Andy Shevchenko wrote: > > On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote: > > > > > pci_get_bus_and_slot() still might be useful for the wired devices > > in > > SoC where we know for sure that domain == 0. > >

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread Sinan Kaya
On 12/19/2017 5:45 AM, Andy Shevchenko wrote: > On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote: >> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as >> where a PCI device is present. This restricts the device drivers to be >> reused for other domain numbers. >> >> Getting

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread Sinan Kaya
On 12/19/2017 5:45 AM, Andy Shevchenko wrote: > On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote: >> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as >> where a PCI device is present. This restricts the device drivers to be >> reused for other domain numbers. >> >> Getting

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread Andy Shevchenko
On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function in

Re: [PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-19 Thread Andy Shevchenko
On Tue, 2017-12-19 at 00:37 -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function in

[PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-18 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Use the domain

[PATCH V4 14/26] pch_gbe: deprecate pci_get_bus_and_slot()

2017-12-18 Thread Sinan Kaya
pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as where a PCI device is present. This restricts the device drivers to be reused for other domain numbers. Getting ready to remove pci_get_bus_and_slot() function in favor of pci_get_domain_bus_and_slot(). Use the domain