Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-25 Thread Alexandre Torgue
On 06/25/2018 03:15 PM, Guenter Roeck wrote: On 06/25/2018 05:52 AM, Alexandre Torgue wrote: Hi Guenter, But you are right I forgot to change stm32f429.dtsi. If I add a commit for stm32f429.dtsi, it's Ok for you ? Not really. You are imposing a personal preference on others, and you

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-25 Thread Alexandre Torgue
On 06/25/2018 03:15 PM, Guenter Roeck wrote: On 06/25/2018 05:52 AM, Alexandre Torgue wrote: Hi Guenter, But you are right I forgot to change stm32f429.dtsi. If I add a commit for stm32f429.dtsi, it's Ok for you ? Not really. You are imposing a personal preference on others, and you

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-25 Thread Guenter Roeck
On 06/25/2018 05:52 AM, Alexandre Torgue wrote: Hi Guenter, But you are right I forgot to change stm32f429.dtsi. If I add a commit for stm32f429.dtsi, it's Ok for you ? Not really. You are imposing a personal preference on others, and you would make stm32f429.dtsi inconsistent since it

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-25 Thread Guenter Roeck
On 06/25/2018 05:52 AM, Alexandre Torgue wrote: Hi Guenter, But you are right I forgot to change stm32f429.dtsi. If I add a commit for stm32f429.dtsi, it's Ok for you ? Not really. You are imposing a personal preference on others, and you would make stm32f429.dtsi inconsistent since it

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-25 Thread Alexandre Torgue
Hi Guenter, But you are right I forgot to change stm32f429.dtsi. If I add a commit for stm32f429.dtsi, it's Ok for you ? Not really. You are imposing a personal preference on others, and you would make stm32f429.dtsi inconsistent since it doesn't use clock names for anything else.This in

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-25 Thread Alexandre Torgue
Hi Guenter, But you are right I forgot to change stm32f429.dtsi. If I add a commit for stm32f429.dtsi, it's Ok for you ? Not really. You are imposing a personal preference on others, and you would make stm32f429.dtsi inconsistent since it doesn't use clock names for anything else.This in

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-22 Thread Guenter Roeck
On 06/22/2018 02:15 AM, Ludovic BARRE wrote: On 06/21/2018 06:53 PM, Guenter Roeck wrote: On Thu, Jun 21, 2018 at 11:02:15AM +0200, Ludovic Barre wrote: From: Ludovic Barre This patch adds compatible data to manage pclk clock by compatible. Adds stm32mp1 support which requires pclk clock.

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-22 Thread Guenter Roeck
On 06/22/2018 02:15 AM, Ludovic BARRE wrote: On 06/21/2018 06:53 PM, Guenter Roeck wrote: On Thu, Jun 21, 2018 at 11:02:15AM +0200, Ludovic Barre wrote: From: Ludovic Barre This patch adds compatible data to manage pclk clock by compatible. Adds stm32mp1 support which requires pclk clock.

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-22 Thread Ludovic BARRE
On 06/21/2018 06:53 PM, Guenter Roeck wrote: On Thu, Jun 21, 2018 at 11:02:15AM +0200, Ludovic Barre wrote: From: Ludovic Barre This patch adds compatible data to manage pclk clock by compatible. Adds stm32mp1 support which requires pclk clock. Signed-off-by: Ludovic Barre ---

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-22 Thread Ludovic BARRE
On 06/21/2018 06:53 PM, Guenter Roeck wrote: On Thu, Jun 21, 2018 at 11:02:15AM +0200, Ludovic Barre wrote: From: Ludovic Barre This patch adds compatible data to manage pclk clock by compatible. Adds stm32mp1 support which requires pclk clock. Signed-off-by: Ludovic Barre ---

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-21 Thread Guenter Roeck
On Thu, Jun 21, 2018 at 11:02:15AM +0200, Ludovic Barre wrote: > From: Ludovic Barre > > This patch adds compatible data to manage pclk clock by > compatible. Adds stm32mp1 support which requires pclk clock. > > Signed-off-by: Ludovic Barre > --- > drivers/watchdog/stm32_iwdg.c | 116 >

Re: [PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-21 Thread Guenter Roeck
On Thu, Jun 21, 2018 at 11:02:15AM +0200, Ludovic Barre wrote: > From: Ludovic Barre > > This patch adds compatible data to manage pclk clock by > compatible. Adds stm32mp1 support which requires pclk clock. > > Signed-off-by: Ludovic Barre > --- > drivers/watchdog/stm32_iwdg.c | 116 >

[PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-21 Thread Ludovic Barre
From: Ludovic Barre This patch adds compatible data to manage pclk clock by compatible. Adds stm32mp1 support which requires pclk clock. Signed-off-by: Ludovic Barre --- drivers/watchdog/stm32_iwdg.c | 116 +++--- 1 file changed, 74 insertions(+), 42

[PATCH V4 2/4] watchdog: stm32: add pclk feature for stm32mp1

2018-06-21 Thread Ludovic Barre
From: Ludovic Barre This patch adds compatible data to manage pclk clock by compatible. Adds stm32mp1 support which requires pclk clock. Signed-off-by: Ludovic Barre --- drivers/watchdog/stm32_iwdg.c | 116 +++--- 1 file changed, 74 insertions(+), 42