Hello,
On Mon, Mar 18, 2019 at 02:04:00PM +, Anson Huang wrote:
> > > On Mon, Mar 18, 2019 at 07:41:02AM +, Anson Huang wrote:
> > > > > > + val &= ~PWM_IMX_TPM_SC_CMOD;
> > > > > > + writel(val, tpm->base + PWM_IMX_TPM_SC);
> > > > >
> > > > > As this interrupts the output, please
@armlinux.org.uk; ota...@ossystems.com.br;
> ste...@agner.ch; Leonard Crestez ;
> schnitzelt...@gmail.com; jan.tu...@emtrion.com; Robin Gong
> ; linux-...@vger.kernel.org;
> devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-
> ker...@vger.kernel.org; dl-linux-imx
> Subjec
Hello,
as you got some feedback for v5 already I assume you will post a v6.
I'll skip reviewing v5 then.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König|
Industrial Linux Solutions | http://www.pengutronix.de/ |
ker...@vger.kernel.org; dl-linux-imx
> Subject: RE: [PATCH V4 2/5] pwm: Add i.MX TPM PWM driver support
>
> Hi, Uwe
>
> Best Regards!
> Anson Huang
>
> > -Original Message-
> > From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de]
> > Sent: 2
lists.infradead.org; linux-
> ker...@vger.kernel.org; dl-linux-imx
> Subject: Re: [PATCH V4 2/5] pwm: Add i.MX TPM PWM driver support
>
> On Mon, Mar 18, 2019 at 07:41:02AM +, Anson Huang wrote:
> > Hi,Uwe
> > > > + val &= ~PWM_IMX_
On Mon, Mar 18, 2019 at 07:41:02AM +, Anson Huang wrote:
> Hi,Uwe
> > > + val &= ~PWM_IMX_TPM_SC_CMOD;
> > > + writel(val, tpm->base + PWM_IMX_TPM_SC);
> >
> > As this interrupts the output, please only do it if necessary.
>
> OK, will do it ONLY when it is enabled previously.
I think you
lists.infradead.org; linux-
> ker...@vger.kernel.org; dl-linux-imx
> Subject: Re: [PATCH V4 2/5] pwm: Add i.MX TPM PWM driver support
>
> On Fri, Mar 15, 2019 at 12:46:51AM +, Anson Huang wrote:
> > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module)
> &g
On Fri, Mar 15, 2019 at 12:46:51AM +, Anson Huang wrote:
> i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module)
> inside, add TPM PWM driver support.
>
> Signed-off-by: Anson Huang
> ---
> Changes since V3:
> - use "PWM_IMX_" as macro definition prefix and "pwm_imx_" as
i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module)
inside, add TPM PWM driver support.
Signed-off-by: Anson Huang
---
Changes since V3:
- use "PWM_IMX_" as macro definition prefix and "pwm_imx_" as function
prefix;
- improve the limitation txt;
- return
9 matches
Mail list logo
