Re: [PATCH V4 5/5] gpio: gpio-xilinx: Add check if width exceeds 32

2021-01-07 Thread Michal Simek
On 07. 01. 21 11:47, Linus Walleij wrote: > On Thu, Jan 7, 2021 at 11:29 AM Michal Simek wrote: >> On 07. 01. 21 11:17, Linus Walleij wrote: >>> On Wed, Jan 6, 2021 at 1:27 PM Srinivas Neeli >>> wrote: > @@ -591,6 +591,9 @@ static int xgpio_probe(struct platform_device *pdev)

Re: [PATCH V4 5/5] gpio: gpio-xilinx: Add check if width exceeds 32

2021-01-07 Thread Linus Walleij
On Thu, Jan 7, 2021 at 11:29 AM Michal Simek wrote: > On 07. 01. 21 11:17, Linus Walleij wrote: > > On Wed, Jan 6, 2021 at 1:27 PM Srinivas Neeli > > wrote: > >> @@ -591,6 +591,9 @@ static int xgpio_probe(struct platform_device *pdev) > >> if (of_property_read_u32(np,

Re: [PATCH V4 5/5] gpio: gpio-xilinx: Add check if width exceeds 32

2021-01-07 Thread Michal Simek
On 07. 01. 21 11:17, Linus Walleij wrote: > On Wed, Jan 6, 2021 at 1:27 PM Srinivas Neeli > wrote: > >> Add check to see if gpio-width property does not exceed 32. >> If it exceeds then return -EINVAL. >> >> Signed-off-by: Srinivas Neeli > > Aha > >> @@ -591,6 +591,9 @@ static int

Re: [PATCH V4 5/5] gpio: gpio-xilinx: Add check if width exceeds 32

2021-01-07 Thread Linus Walleij
On Wed, Jan 6, 2021 at 1:27 PM Srinivas Neeli wrote: > Add check to see if gpio-width property does not exceed 32. > If it exceeds then return -EINVAL. > > Signed-off-by: Srinivas Neeli Aha > @@ -591,6 +591,9 @@ static int xgpio_probe(struct platform_device *pdev) > if

[PATCH V4 5/5] gpio: gpio-xilinx: Add check if width exceeds 32

2021-01-06 Thread Srinivas Neeli
Add check to see if gpio-width property does not exceed 32. If it exceeds then return -EINVAL. Signed-off-by: Srinivas Neeli --- Changes in V4: -New patch. --- drivers/gpio/gpio-xilinx.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpio/gpio-xilinx.c