Re: [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-19 Thread Guo Ren
Hi Marc, On Tue, Sep 18, 2018 at 04:41:22PM +0100, Marc Zyngier wrote: > > +#define IPI_IRQ15 > > + > > It feels really bizarre that the function that maps the interrupt is > specific to the interrupt controller, and yet the interrupt number is > defined at the architecture level. I'd expect

Re: [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-18 Thread Marc Zyngier
On Tue, 18 Sep 2018 09:43:31 +0100, Guo Ren wrote: > > On Mon, Sep 17, 2018 at 02:27:31PM +0100, Marc Zyngier wrote: > > On Mon, 17 Sep 2018 03:09:29 +0100, > > Guo Ren wrote: > > > > [...] > > > > > > > + > > > > > + irq_set_default_host(root_domain); > > > > > > > > Please drop this. Th

Re: [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-18 Thread Guo Ren
On Mon, Sep 17, 2018 at 02:27:31PM +0100, Marc Zyngier wrote: > On Mon, 17 Sep 2018 03:09:29 +0100, > Guo Ren wrote: > > [...] > > > > > + > > > > + irq_set_default_host(root_domain); > > > > > > Please drop this. There is no reason to use this on any modern, DT > > > based architecture.

Re: [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-17 Thread Marc Zyngier
On Mon, 17 Sep 2018 03:09:29 +0100, Guo Ren wrote: [...] > > > + > > > + irq_set_default_host(root_domain); > > > > Please drop this. There is no reason to use this on any modern, DT > > based architecture. > Please let me keep this and in my arch/csky/kernel/smp.c: > > void __init setup_smp_i

Re: [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-16 Thread Guo Ren
On Sun, Sep 16, 2018 at 08:07:55PM +0100, Marc Zyngier wrote: > On Sun, 16 Sep 2018 09:50:02 +0100, > Guo Ren wrote: > > +static void csky_mpintc_handler(struct pt_regs *regs) > > +{ > > + void __iomem *reg_base = this_cpu_read(intcl_reg); > > + > > + do { > > + handle_domain_irq(NUL

Re: [PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-16 Thread Marc Zyngier
On Sun, 16 Sep 2018 09:50:02 +0100, Guo Ren wrote: > > This patch add C-SKY two interrupt conrollers. > > - irq-csky-apb-intc is a simple SOC interrupt controller which is >used in a lot of C-SKY SOC products. > > - irq-csky-mpintc is C-SKY smp system interrupt controller and it >coul

[PATCH V5 1/3] irqchip: add C-SKY irqchip drivers

2018-09-16 Thread Guo Ren
This patch add C-SKY two interrupt conrollers. - irq-csky-apb-intc is a simple SOC interrupt controller which is used in a lot of C-SKY SOC products. - irq-csky-mpintc is C-SKY smp system interrupt controller and it could support 16 soft irqs, 16 private irqs, and 992 max common irqs.