Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-05-14 Thread Tejun Heo
From cee22a15052faa817e3ec8985a28154d3fabc7aa Mon Sep 17 00:00:00 2001 From: Viresh Kumar viresh.ku...@linaro.org Date: Mon, 8 Apr 2013 16:45:40 +0530 Subject: workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues Workqueues can be performance or power-oriented.

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-05-13 Thread Viresh Kumar
:40 +0530 Subject: [PATCH V5 resent 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues Workqueues can be performance or power-oriented. Currently, most workqueues are bound to the CPU they were created on. This gives good performance (due to cache effects

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-29 Thread Viresh Kumar
Hey Tejun, On 27 April 2013 00:41, Tejun Heo t...@kernel.org wrote: Hey, Viresh. It's already too late for the upcoming merge window, but things generally look good to me and I'll apply the patchset once wq/for-3.11 opens. One nitpick tho. Obviously. I understand this and agree with you on

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-29 Thread Tejun Heo
Hello, On Mon, Apr 29, 2013 at 12:06:28PM +0530, Viresh Kumar wrote: Whatever you wrote above confused me even more :) Heh heh, confumageddon This is what i had in my mind until now. Its not about per-cpu workqueue. Lets take example of system_wq. It doesn't have WQ_UNBOUND flag set.

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-29 Thread Viresh Kumar
On 29 April 2013 21:49, Tejun Heo t...@kernel.org wrote: On Mon, Apr 29, 2013 at 12:06:28PM +0530, Viresh Kumar wrote: Yeap, !WQ_UNBOUND workqueues == per-cpu workqueues. Sigh!! You were talking about thread per cpu here... Sorry for missing it earlier :( At this time local cpu may be busy or

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-26 Thread Tejun Heo
Hey, Viresh. It's already too late for the upcoming merge window, but things generally look good to me and I'll apply the patchset once wq/for-3.11 opens. One nitpick tho. On Thu, Apr 25, 2013 at 09:13:44AM +0530, Viresh Kumar wrote: + workqueue.power_efficient +

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-25 Thread Amit Kucheria
:45:40 +0530 Subject: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues Workqueues can be performance or power-oriented. Currently, most workqueues are bound to the CPU they were created on. This gives good performance (due to cache effects

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-25 Thread Viresh Kumar
- From: Viresh Kumar viresh.ku...@linaro.org Date: Mon, 8 Apr 2013 16:45:40 +0530 Subject: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues Workqueues can be performance or power-oriented. Currently, most workqueues are bound to the CPU

[PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-24 Thread Viresh Kumar
Workqueues can be performance or power oriented. For performance we may want to keep them running on a single cpu, so that it remains cache hot. For power we can give scheduler the liberty to choose target cpu for running work handler. Later one (Power oriented WQ) can be achieved if the

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-24 Thread Amit Kucheria
On Wed, Apr 24, 2013 at 5:12 PM, Viresh Kumar viresh.ku...@linaro.org wrote: Workqueues can be performance or power oriented. For performance we may want to keep them running on a single cpu, so that it remains cache hot. For power we can give scheduler the liberty to choose target cpu for

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-24 Thread Viresh Kumar
On 24 April 2013 17:50, Amit Kucheria amit.kuche...@linaro.org wrote: On Wed, Apr 24, 2013 at 5:12 PM, Viresh Kumar viresh.ku...@linaro.org wrote: +config WQ_POWER_EFFICIENT + bool Workqueue allocated as UNBOUND (by default) for power efficiency + depends on PM default n If

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-24 Thread Tejun Heo
On Wed, Apr 24, 2013 at 05:57:09PM +0530, Viresh Kumar wrote: If this line is not present i believe it is 'default n' only. So, i skipped it. I think the difference is that when you configure the option for the first time - ie. building kernel with .config used for an older kernel - that it

Re: [PATCH V5 1/5] workqueues: Introduce new flag WQ_POWER_EFFICIENT for power oriented workqueues

2013-04-24 Thread Viresh Kumar
as gmail's copy-paste may break it. Please consider applying this series if it looks fine to you. ---xx- From: Viresh Kumar viresh.ku...@linaro.org Date: Mon, 8 Apr 2013 16:45:40 +0530 Subject: [PATCH V5 1/5] workqueues: Introduce new flag