Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-08-02 Thread Dmitry Osipenko
02.08.2019 16:05, Peter De Schrijver пишет: > On Thu, Jul 25, 2019 at 01:59:09PM +0300, Dmitry Osipenko wrote: >> 25.07.2019 13:38, Peter De Schrijver пишет: >>> On Thu, Jul 25, 2019 at 01:33:48PM +0300, Peter De Schrijver wrote: On Thu, Jul 25, 2019 at 01:05:13PM +0300, Dmitry Osipenko

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-08-02 Thread Peter De Schrijver
On Thu, Jul 25, 2019 at 01:59:09PM +0300, Dmitry Osipenko wrote: > 25.07.2019 13:38, Peter De Schrijver пишет: > > On Thu, Jul 25, 2019 at 01:33:48PM +0300, Peter De Schrijver wrote: > >> On Thu, Jul 25, 2019 at 01:05:13PM +0300, Dmitry Osipenko wrote: > >>> 25.07.2019 12:55, Peter De Schrijver

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-25 Thread Dmitry Osipenko
В Wed, 24 Jul 2019 16:09:53 -0700 Sowjanya Komatineni пишет: > On 7/22/19 4:35 PM, Dmitry Osipenko wrote: > > 22.07.2019 21:38, Marc Zyngier пишет: > >> On Mon, 22 Jul 2019 09:21:21 -0700 > >> Sowjanya Komatineni wrote: > >> > >>> On 7/22/19 3:57 AM, Dmitry Osipenko wrote: >

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-25 Thread Dmitry Osipenko
25.07.2019 13:38, Peter De Schrijver пишет: > On Thu, Jul 25, 2019 at 01:33:48PM +0300, Peter De Schrijver wrote: >> On Thu, Jul 25, 2019 at 01:05:13PM +0300, Dmitry Osipenko wrote: >>> 25.07.2019 12:55, Peter De Schrijver пишет: On Mon, Jul 22, 2019 at 12:54:51PM +0300, Dmitry Osipenko

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-25 Thread Peter De Schrijver
On Thu, Jul 25, 2019 at 01:33:48PM +0300, Peter De Schrijver wrote: > On Thu, Jul 25, 2019 at 01:05:13PM +0300, Dmitry Osipenko wrote: > > 25.07.2019 12:55, Peter De Schrijver пишет: > > > On Mon, Jul 22, 2019 at 12:54:51PM +0300, Dmitry Osipenko wrote: > > >> > > >> All Tegra SoCs support SC7,

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-25 Thread Peter De Schrijver
On Thu, Jul 25, 2019 at 01:05:13PM +0300, Dmitry Osipenko wrote: > 25.07.2019 12:55, Peter De Schrijver пишет: > > On Mon, Jul 22, 2019 at 12:54:51PM +0300, Dmitry Osipenko wrote: > >> > >> All Tegra SoCs support SC7, hence the 'supports_sc7' and the comment > >> doesn't sound correct to me.

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-25 Thread Dmitry Osipenko
25.07.2019 12:55, Peter De Schrijver пишет: > On Mon, Jul 22, 2019 at 12:54:51PM +0300, Dmitry Osipenko wrote: >> >> All Tegra SoCs support SC7, hence the 'supports_sc7' and the comment >> doesn't sound correct to me. Something like 'firmware_sc7' should suit >> better here. >> >>> +

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-25 Thread Peter De Schrijver
On Mon, Jul 22, 2019 at 12:54:51PM +0300, Dmitry Osipenko wrote: > > All Tegra SoCs support SC7, hence the 'supports_sc7' and the comment > doesn't sound correct to me. Something like 'firmware_sc7' should suit > better here. > > > + writel_relaxed(~0ul, ictlr +

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-24 Thread Sowjanya Komatineni
On 7/22/19 4:35 PM, Dmitry Osipenko wrote: 22.07.2019 21:38, Marc Zyngier пишет: On Mon, 22 Jul 2019 09:21:21 -0700 Sowjanya Komatineni wrote: On 7/22/19 3:57 AM, Dmitry Osipenko wrote: 22.07.2019 13:13, Marc Zyngier пишет: On 22/07/2019 10:54, Dmitry Osipenko wrote: 21.07.2019 22:40,

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-22 Thread Dmitry Osipenko
22.07.2019 21:38, Marc Zyngier пишет: > On Mon, 22 Jul 2019 09:21:21 -0700 > Sowjanya Komatineni wrote: > >> On 7/22/19 3:57 AM, Dmitry Osipenko wrote: >>> 22.07.2019 13:13, Marc Zyngier пишет: On 22/07/2019 10:54, Dmitry Osipenko wrote: > 21.07.2019 22:40, Sowjanya Komatineni

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-22 Thread Marc Zyngier
On Mon, 22 Jul 2019 09:21:21 -0700 Sowjanya Komatineni wrote: > On 7/22/19 3:57 AM, Dmitry Osipenko wrote: > > 22.07.2019 13:13, Marc Zyngier пишет: > >> On 22/07/2019 10:54, Dmitry Osipenko wrote: > >>> 21.07.2019 22:40, Sowjanya Komatineni пишет: > Tegra210 platforms use sc7 entry

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-22 Thread Sowjanya Komatineni
On 7/22/19 3:57 AM, Dmitry Osipenko wrote: 22.07.2019 13:13, Marc Zyngier пишет: On 22/07/2019 10:54, Dmitry Osipenko wrote: 21.07.2019 22:40, Sowjanya Komatineni пишет: Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry sequence and sc7 entry firmware is run from

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-22 Thread Dmitry Osipenko
22.07.2019 13:13, Marc Zyngier пишет: > On 22/07/2019 10:54, Dmitry Osipenko wrote: >> 21.07.2019 22:40, Sowjanya Komatineni пишет: >>> Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry >>> sequence and sc7 entry firmware is run from COP/BPMP-Lite. >>> >>> So, COP/BPMP-Lite

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-22 Thread Marc Zyngier
On 22/07/2019 10:54, Dmitry Osipenko wrote: > 21.07.2019 22:40, Sowjanya Komatineni пишет: >> Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry >> sequence and sc7 entry firmware is run from COP/BPMP-Lite. >> >> So, COP/BPMP-Lite still need IRQ function to finish SC7 suspend

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-22 Thread Dmitry Osipenko
21.07.2019 22:40, Sowjanya Komatineni пишет: > Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry > sequence and sc7 entry firmware is run from COP/BPMP-Lite. > > So, COP/BPMP-Lite still need IRQ function to finish SC7 suspend sequence > for Tegra210. > > This patch has fix

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-21 Thread Marc Zyngier
On Sun, 21 Jul 2019 12:40:40 -0700 Sowjanya Komatineni wrote: > Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry > sequence and sc7 entry firmware is run from COP/BPMP-Lite. > > So, COP/BPMP-Lite still need IRQ function to finish SC7 suspend sequence > for Tegra210. > >

[PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-21 Thread Sowjanya Komatineni
Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry sequence and sc7 entry firmware is run from COP/BPMP-Lite. So, COP/BPMP-Lite still need IRQ function to finish SC7 suspend sequence for Tegra210. This patch has fix for leaving the COP IRQ enabled for Tegra210 during