Re: [PATCH V7 04/15] kprobes: Add perf ksymbol events for kprobe insn pages

2020-05-28 Thread Adrian Hunter
On 27/05/20 8:20 pm, Peter Zijlstra wrote: > On Wed, May 27, 2020 at 06:17:32PM +0200, Peter Zijlstra wrote: >> On Tue, May 12, 2020 at 03:19:11PM +0300, Adrian Hunter wrote: >>> @@ -202,6 +207,13 @@ static int collect_one_slot(struct kprobe_insn_page >>> *kip, int idx) >>> * next

Re: [PATCH V7 04/15] kprobes: Add perf ksymbol events for kprobe insn pages

2020-05-27 Thread Peter Zijlstra
On Wed, May 27, 2020 at 06:17:32PM +0200, Peter Zijlstra wrote: > On Tue, May 12, 2020 at 03:19:11PM +0300, Adrian Hunter wrote: > > @@ -202,6 +207,13 @@ static int collect_one_slot(struct kprobe_insn_page > > *kip, int idx) > > * next time somebody inserts a probe. > >

Re: [PATCH V7 04/15] kprobes: Add perf ksymbol events for kprobe insn pages

2020-05-27 Thread Peter Zijlstra
On Tue, May 12, 2020 at 03:19:11PM +0300, Adrian Hunter wrote: > @@ -202,6 +207,13 @@ static int collect_one_slot(struct kprobe_insn_page > *kip, int idx) >* next time somebody inserts a probe. >*/ > if (!list_is_singular(>list)) { > +

[PATCH V7 04/15] kprobes: Add perf ksymbol events for kprobe insn pages

2020-05-12 Thread Adrian Hunter
Symbols are needed for tools to describe instruction addresses. Pages allocated for kprobe's purposes need symbols to be created for them. Add such symbols to be visible via perf ksymbol events. Signed-off-by: Adrian Hunter Acked-by: Masami Hiramatsu Acked-by: Peter Zijlstra (Intel) ---