Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-17 Thread Catalin Marinas
On Tue, Sep 17, 2019 at 10:06:11AM +0530, Anshuman Khandual wrote: > On 09/13/2019 03:39 PM, Catalin Marinas wrote: > > On Fri, Sep 13, 2019 at 11:28:01AM +0530, Anshuman Khandual wrote: > >> The problem (race) is not because of the inability to deal with partially > >> filled table. We can handle

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-16 Thread Anshuman Khandual
On 09/13/2019 03:39 PM, Catalin Marinas wrote: > On Fri, Sep 13, 2019 at 11:28:01AM +0530, Anshuman Khandual wrote: >> On 09/13/2019 01:45 AM, Catalin Marinas wrote: >>> On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: @@ -770,6 +1022,28 @@ int __meminit

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-13 Thread Catalin Marinas
On Fri, Sep 13, 2019 at 11:28:01AM +0530, Anshuman Khandual wrote: > On 09/13/2019 01:45 AM, Catalin Marinas wrote: > > On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: > >> @@ -770,6 +1022,28 @@ int __meminit vmemmap_populate(unsigned long start, > >> unsigned long end, int

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-12 Thread Anshuman Khandual
On 09/13/2019 01:45 AM, Catalin Marinas wrote: > Hi Anshuman, > > Thanks for the details on the need for removing the page tables and > vmemmap backing. Some comments on the code below. > > On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: >> --- a/arch/arm64/mm/mmu.c >> +++

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-12 Thread Catalin Marinas
Hi Anshuman, Thanks for the details on the need for removing the page tables and vmemmap backing. Some comments on the code below. On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: > --- a/arch/arm64/mm/mmu.c > +++ b/arch/arm64/mm/mmu.c > @@ -60,6 +60,14 @@ static pud_t

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-12 Thread Anshuman Khandual
On 09/12/2019 09:58 AM, Anshuman Khandual wrote: > > On 09/10/2019 09:47 PM, Catalin Marinas wrote: >> On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: >>> @@ -770,6 +1022,28 @@ int __meminit vmemmap_populate(unsigned long start, >>> unsigned long end, int node, >>> void

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-11 Thread Anshuman Khandual
On 09/10/2019 09:47 PM, Catalin Marinas wrote: > On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: >> @@ -770,6 +1022,28 @@ int __meminit vmemmap_populate(unsigned long start, >> unsigned long end, int node, >> void vmemmap_free(unsigned long start, unsigned long end, >>

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-11 Thread David Hildenbrand
On 10.09.19 18:17, Catalin Marinas wrote: > On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: >> @@ -770,6 +1022,28 @@ int __meminit vmemmap_populate(unsigned long start, >> unsigned long end, int node, >> void vmemmap_free(unsigned long start, unsigned long end, >>

Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-10 Thread Catalin Marinas
On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: > @@ -770,6 +1022,28 @@ int __meminit vmemmap_populate(unsigned long start, > unsigned long end, int node, > void vmemmap_free(unsigned long start, unsigned long end, > struct vmem_altmap *altmap) > { > +#ifdef

[PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-03 Thread Anshuman Khandual
The arch code for hot-remove must tear down portions of the linear map and vmemmap corresponding to memory being removed. In both cases the page tables mapping these regions must be freed, and when sparse vmemmap is in use the memory backing the vmemmap must also be freed. This patch adds a new