Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 4:35 PM Sven Van Asbroeck wrote: > On Thu, Nov 8, 2018 at 9:20 AM Arnd Bergmann wrote: > > + struct { > > > + /* addresses IN NETWORK ORDER! */ > > > + __u32 ip_addr; > > > + __u32 subnet_msk; > > > + __u32

Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Arnd Bergmann
On Thu, Nov 8, 2018 at 4:35 PM Sven Van Asbroeck wrote: > On Thu, Nov 8, 2018 at 9:20 AM Arnd Bergmann wrote: > > + struct { > > > + /* addresses IN NETWORK ORDER! */ > > > + __u32 ip_addr; > > > + __u32 subnet_msk; > > > + __u32

Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Sven Van Asbroeck
Hi Arnd, These are great questions, I had been wondering when they would be brought up :) On Thu, Nov 8, 2018 at 9:20 AM Arnd Bergmann wrote: > > I don't understand much about field bus, but I have a general feeling > that if you configure a mac address and IP address, this should > be connect

Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Sven Van Asbroeck
Hi Arnd, These are great questions, I had been wondering when they would be brought up :) On Thu, Nov 8, 2018 at 9:20 AM Arnd Bergmann wrote: > > I don't understand much about field bus, but I have a general feeling > that if you configure a mac address and IP address, this should > be connect

Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Arnd Bergmann
On Sun, Nov 4, 2018 at 4:55 PM wrote: > + > +struct msgEthConfig { > + u32 ip_addr, subnet_msk, gateway_addr; > +} __packed; The __packed attribute makes it slower to access but doesn't change the layout, so better drop it. > +struct msgMacAddr { > + u8 addr[6]; > +} __packed; > +

Re: [PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-08 Thread Arnd Bergmann
On Sun, Nov 4, 2018 at 4:55 PM wrote: > + > +struct msgEthConfig { > + u32 ip_addr, subnet_msk, gateway_addr; > +} __packed; The __packed attribute makes it slower to access but doesn't change the layout, so better drop it. > +struct msgMacAddr { > + u8 addr[6]; > +} __packed; > +

[PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official

[PATCH anybus v3 6/6] misc: support HMS Profinet IRT industrial controller

2018-11-04 Thread thesven73
From: Sven Van Asbroeck The Anybus-S PROFINET IRT communication module provides instant integration to any Ethernet based LAN via SMTP, FTP, HTTP as well as PROFINET and Modbus-TCP. Additional protocols can be implemented on top of TCP/IP or UDP using the transparent socket interface. Official