Re: [PATCH bpf-next v2] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-04-03 Thread Andrii Nakryiko
On Sat, Apr 3, 2021 at 6:29 AM Pedro Tammela wrote: > > Em qua., 31 de mar. de 2021 às 04:02, Andrii Nakryiko > escreveu: > > > > On Tue, Mar 30, 2021 at 4:16 PM Alexei Starovoitov > > wrote: > > > > > > On Tue, Mar 30, 2021 at 3:54 PM Pedro Tammela wrote: > > > > > > > >

Re: [PATCH bpf-next v2] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-04-03 Thread Pedro Tammela
Em qua., 31 de mar. de 2021 às 04:02, Andrii Nakryiko escreveu: > > On Tue, Mar 30, 2021 at 4:16 PM Alexei Starovoitov > wrote: > > > > On Tue, Mar 30, 2021 at 3:54 PM Pedro Tammela wrote: > > > > > > BPF_CALL_2(bpf_ringbuf_submit, void *, sample, u64, flags) > > > { > > > + if

Re: [PATCH bpf-next v2] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-03-31 Thread Andrii Nakryiko
On Tue, Mar 30, 2021 at 4:16 PM Alexei Starovoitov wrote: > > On Tue, Mar 30, 2021 at 3:54 PM Pedro Tammela wrote: > > > > BPF_CALL_2(bpf_ringbuf_submit, void *, sample, u64, flags) > > { > > + if (unlikely(flags & ~(BPF_RB_NO_WAKEUP | BPF_RB_FORCE_WAKEUP))) > > + return

Re: [PATCH bpf-next v2] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-03-30 Thread Alexei Starovoitov
On Tue, Mar 30, 2021 at 3:54 PM Pedro Tammela wrote: > > BPF_CALL_2(bpf_ringbuf_submit, void *, sample, u64, flags) > { > + if (unlikely(flags & ~(BPF_RB_NO_WAKEUP | BPF_RB_FORCE_WAKEUP))) > + return -EINVAL; > + > bpf_ringbuf_commit(sample, flags, false /* discard

Re: [PATCH bpf-next v2] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-03-30 Thread Song Liu
> On Mar 30, 2021, at 3:37 PM, Pedro Tammela wrote: > > The current code only checks flags in 'bpf_ringbuf_output()'. > > Signed-off-by: Pedro Tammela Acked-by: Song Liu

[PATCH bpf-next v2] bpf: check flags in 'bpf_ringbuf_discard()' and 'bpf_ringbuf_submit()'

2021-03-30 Thread Pedro Tammela
The current code only checks flags in 'bpf_ringbuf_output()'. Signed-off-by: Pedro Tammela --- include/uapi/linux/bpf.h | 8 kernel/bpf/ringbuf.c | 13 +++-- tools/include/uapi/linux/bpf.h | 8 3 files changed, 19 insertions(+), 10 deletions(-) diff