Re: [PATCH bpf-next v2 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf

2021-04-08 Thread Florent Revest
On Wed, Apr 7, 2021 at 11:54 PM Andrii Nakryiko wrote: > On Tue, Apr 6, 2021 at 8:35 AM Florent Revest wrote: > > On Fri, Mar 26, 2021 at 11:51 PM Andrii Nakryiko > > wrote: > > > On Fri, Mar 26, 2021 at 2:53 PM Andrii Nakryiko > > > wrote: > > > > On Tue, Mar 23, 2021 at 7:23 PM Florent

Re: [PATCH bpf-next v2 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf

2021-04-07 Thread Andrii Nakryiko
On Tue, Apr 6, 2021 at 8:35 AM Florent Revest wrote: > > [Sorry for the late replies, I'm just back from a long easter break :)] > > On Fri, Mar 26, 2021 at 11:51 PM Andrii Nakryiko > wrote: > > On Fri, Mar 26, 2021 at 2:53 PM Andrii Nakryiko > > wrote: > > > On Tue, Mar 23, 2021 at 7:23 PM

Re: [PATCH bpf-next v2 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf

2021-04-06 Thread Florent Revest
[Sorry for the late replies, I'm just back from a long easter break :)] On Fri, Mar 26, 2021 at 11:51 PM Andrii Nakryiko wrote: > On Fri, Mar 26, 2021 at 2:53 PM Andrii Nakryiko > wrote: > > On Tue, Mar 23, 2021 at 7:23 PM Florent Revest wrote: > > > Unfortunately, the implementation of the

Re: [PATCH bpf-next v2 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf

2021-03-26 Thread Andrii Nakryiko
On Fri, Mar 26, 2021 at 2:53 PM Andrii Nakryiko wrote: > > On Tue, Mar 23, 2021 at 7:23 PM Florent Revest wrote: > > > > Two helpers (trace_printk and seq_printf) have very similar > > implementations of format string parsing and a third one is coming > > (snprintf). To avoid code duplication

Re: [PATCH bpf-next v2 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf

2021-03-26 Thread Andrii Nakryiko
On Tue, Mar 23, 2021 at 7:23 PM Florent Revest wrote: > > Two helpers (trace_printk and seq_printf) have very similar > implementations of format string parsing and a third one is coming > (snprintf). To avoid code duplication and make the code easier to > maintain, this moves the operations

[PATCH bpf-next v2 1/6] bpf: Factorize bpf_trace_printk and bpf_seq_printf

2021-03-23 Thread Florent Revest
Two helpers (trace_printk and seq_printf) have very similar implementations of format string parsing and a third one is coming (snprintf). To avoid code duplication and make the code easier to maintain, this moves the operations associated with format string parsing (validation and argument