Re: [PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

2017-01-16 Thread Jakub Kicinski
On Mon, Jan 16, 2017 at 10:29 AM, Luis R. Rodriguez wrote: > On Mon, Jan 16, 2017 at 02:57:06PM +, Jakub Kicinski wrote: >> Commit 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() >> return value") made the assumption that any error returned from >>

Re: [PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

2017-01-16 Thread Jakub Kicinski
On Mon, Jan 16, 2017 at 10:29 AM, Luis R. Rodriguez wrote: > On Mon, Jan 16, 2017 at 02:57:06PM +, Jakub Kicinski wrote: >> Commit 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() >> return value") made the assumption that any error returned from >> fw_state_wait_timeout() means

Re: [PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

2017-01-16 Thread Luis R. Rodriguez
On Mon, Jan 16, 2017 at 02:57:06PM +, Jakub Kicinski wrote: > Commit 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() > return value") made the assumption that any error returned from > fw_state_wait_timeout() means FW load has to be aborted. This is > incorrect FW load only has

Re: [PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

2017-01-16 Thread Luis R. Rodriguez
On Mon, Jan 16, 2017 at 02:57:06PM +, Jakub Kicinski wrote: > Commit 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() > return value") made the assumption that any error returned from > fw_state_wait_timeout() means FW load has to be aborted. This is > incorrect FW load only has

[PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

2017-01-16 Thread Jakub Kicinski
Commit 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() return value") made the assumption that any error returned from fw_state_wait_timeout() means FW load has to be aborted. This is incorrect FW load only has to be aborted when load timed out or has been interrupted, otherwise the

[PATCH driver-core/master] firmware: Correct handling of fw_state_wait_timeout() return value

2017-01-16 Thread Jakub Kicinski
Commit 5d47ec02c37e ("firmware: Correct handling of fw_state_wait() return value") made the assumption that any error returned from fw_state_wait_timeout() means FW load has to be aborted. This is incorrect FW load only has to be aborted when load timed out or has been interrupted, otherwise the