Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"

2017-12-19 Thread Brian Norris
On Tue, Dec 19, 2017 at 10:58:18AM +, Mark Brown wrote: > It's been applied as a fix for some time. Indeed it has. Sorry for missing that. I look forward to seeing it in a release candidate, so my system will again work on mainline :) Brian

Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"

2017-12-19 Thread Mark Brown
On Mon, Dec 18, 2017 at 09:42:36AM -0800, Brian Norris wrote: > On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote: > >Hi Brian, > > Oder has posted the same fix : [1]https://patchwork.kernel.org/ > >patch/10066257/ and it has been applied. > >Perhaps you can cherry-

Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"

2017-12-18 Thread Cheng-yi Chiang
Hi Brian, I am sorry for not using the plain text mode in the previous mail. I agree with you on other points. On Tue, Dec 19, 2017 at 1:42 AM, Brian Norris wrote: > Hi! > > (By the way, your mail is HTML and likely will get rejected by many > mailing lists and/or people reading these mailing lis

Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"

2017-12-18 Thread Brian Norris
Hi! (By the way, your mail is HTML and likely will get rejected by many mailing lists and/or people reading these mailing lists.) On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote: >Hi Brian, > Oder has posted the same fix : [1]https://patchwork.kernel.org/ >patch/10066

Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"

2017-12-15 Thread Brian Norris
+ others On Fri, Dec 15, 2017 at 05:12:30PM -0800, Brian Norris wrote: > I've found that on Google's "Kevin" Chromebook, the rt5514 codec might > not be set up completely, yet its device is still present, and therefore > its PM suspend/resume is called. This hits a NULL pointer exception, > since

[PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"

2017-12-15 Thread Brian Norris
I've found that on Google's "Kevin" Chromebook, the rt5514 codec might not be set up completely, yet its device is still present, and therefore its PM suspend/resume is called. This hits a NULL pointer exception, since we never had the chance to set our drvdata pointer. This resolves crashes seen