Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

2017-09-29 Thread Wei Hu (Xavier)
On 2017/9/29 18:23, Leon Romanovsky wrote: On Fri, Sep 29, 2017 at 02:07:22PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 20:59, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 17:13, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:2

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

2017-09-29 Thread Leon Romanovsky
On Fri, Sep 29, 2017 at 02:07:22PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 20:59, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: > > > > > > On 2017/9/28 17:13, Leon Romanovsky wrote: > > > > On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xav

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

2017-09-28 Thread Wei Hu (Xavier)
On 2017/9/28 20:59, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: On 2017/9/28 17:13, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou When lp_qp_work is NULL, it should be returned ENOMEM. Thi

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

2017-09-28 Thread Leon Romanovsky
On Thu, Sep 28, 2017 at 07:56:59PM +0800, Wei Hu (Xavier) wrote: > > > On 2017/9/28 17:13, Leon Romanovsky wrote: > > On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: > > > From: Lijun Ou > > > > > > When lp_qp_work is NULL, it should be returned ENOMEM. This patch > > > mainly fix

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

2017-09-28 Thread Wei Hu (Xavier)
On 2017/9/28 17:13, Leon Romanovsky wrote: On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: From: Lijun Ou When lp_qp_work is NULL, it should be returned ENOMEM. This patch mainly fixes it. Ihis patch fixes the smatch error as below: drivers/infiniband/hw/hns/hns_roce_hw_v1.

Re: [PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

2017-09-28 Thread Leon Romanovsky
On Thu, Sep 28, 2017 at 12:57:28PM +0800, Wei Hu (Xavier) wrote: > From: Lijun Ou > > When lp_qp_work is NULL, it should be returned ENOMEM. This patch > mainly fixes it. > > Ihis patch fixes the smatch error as below: > drivers/infiniband/hw/hns/hns_roce_hw_v1.c:918 hns_roce_v1_recreate_lp_qp() >

[PATCH for-next 3/9] RDMA/hns: Add return statement when kzalloc return NULL in hns_roce_v1_recreate_lp_qp

2017-09-27 Thread Wei Hu (Xavier)
From: Lijun Ou When lp_qp_work is NULL, it should be returned ENOMEM. This patch mainly fixes it. Ihis patch fixes the smatch error as below: drivers/infiniband/hw/hns/hns_roce_hw_v1.c:918 hns_roce_v1_recreate_lp_qp() error: potential null dereference 'lp_qp_work'. (kzalloc returns null) Signe