Re: [PATCH i2c-next] i2c: aspeed: Handle master/slave combined irq events properly

2018-07-23 Thread Jae Hyun Yoo
Thanks James for the review. Please see my inline answers. On 7/23/2018 11:10 AM, James Feist wrote: On 07/23/2018 10:48 AM, Jae Hyun Yoo wrote: In most of cases, interrupt bits are set one by one but there are also a lot of other cases that Aspeed I2C IP sends multiple interrupt bits with

Re: [PATCH i2c-next] i2c: aspeed: Handle master/slave combined irq events properly

2018-07-23 Thread Jae Hyun Yoo
Thanks James for the review. Please see my inline answers. On 7/23/2018 11:10 AM, James Feist wrote: On 07/23/2018 10:48 AM, Jae Hyun Yoo wrote: In most of cases, interrupt bits are set one by one but there are also a lot of other cases that Aspeed I2C IP sends multiple interrupt bits with

Re: [PATCH i2c-next] i2c: aspeed: Handle master/slave combined irq events properly

2018-07-23 Thread James Feist
On 07/23/2018 10:48 AM, Jae Hyun Yoo wrote: In most of cases, interrupt bits are set one by one but there are also a lot of other cases that Aspeed I2C IP sends multiple interrupt bits with combining master and slave events using a single interrupt call. It happens much in multi-master

Re: [PATCH i2c-next] i2c: aspeed: Handle master/slave combined irq events properly

2018-07-23 Thread James Feist
On 07/23/2018 10:48 AM, Jae Hyun Yoo wrote: In most of cases, interrupt bits are set one by one but there are also a lot of other cases that Aspeed I2C IP sends multiple interrupt bits with combining master and slave events using a single interrupt call. It happens much in multi-master

[PATCH i2c-next] i2c: aspeed: Handle master/slave combined irq events properly

2018-07-23 Thread Jae Hyun Yoo
In most of cases, interrupt bits are set one by one but there are also a lot of other cases that Aspeed I2C IP sends multiple interrupt bits with combining master and slave events using a single interrupt call. It happens much in multi-master environment than single-master. For an example, when

[PATCH i2c-next] i2c: aspeed: Handle master/slave combined irq events properly

2018-07-23 Thread Jae Hyun Yoo
In most of cases, interrupt bits are set one by one but there are also a lot of other cases that Aspeed I2C IP sends multiple interrupt bits with combining master and slave events using a single interrupt call. It happens much in multi-master environment than single-master. For an example, when