Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place

2021-02-15 Thread Andy Shevchenko
On Mon, Feb 15, 2021 at 03:20:40PM +0200, Andy Shevchenko wrote: > On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote: > > Consolidate pci_free_irq_vectors to a single place using "goto free_irq" > > for simplify the code. FYI, you may rather to introduce a pcim_alloc_irq_vectors() and

Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place

2021-02-15 Thread Andy Shevchenko
On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote: > Consolidate pci_free_irq_vectors to a single place using "goto free_irq" > for simplify the code. One nit below, after addressing: Reviewed-by: Andy Shevchenko ... > +free_irq: It's quite confusing name. I would expect to see here

Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place

2021-02-15 Thread Dejin Zheng
On Mon, Feb 15, 2021 at 11:36:27AM +0200, Jarkko Nikula wrote: > On 2/14/21 8:45 AM, Dejin Zheng wrote: > > Consolidate pci_free_irq_vectors to a single place using "goto free_irq" > > for simplify the code. > > > > Signed-off-by: Dejin Zheng > > --- > >

Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place

2021-02-15 Thread Jarkko Nikula
On 2/14/21 8:45 AM, Dejin Zheng wrote: Consolidate pci_free_irq_vectors to a single place using "goto free_irq" for simplify the code. Signed-off-by: Dejin Zheng --- drivers/i2c/busses/i2c-designware-pcidrv.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-)

[PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place

2021-02-13 Thread Dejin Zheng
Consolidate pci_free_irq_vectors to a single place using "goto free_irq" for simplify the code. Signed-off-by: Dejin Zheng --- drivers/i2c/busses/i2c-designware-pcidrv.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git