Re: [PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed,timeout' DT property reading code

2018-09-27 Thread Jae Hyun Yoo
Hi Joel, On 9/26/2018 8:11 PM, Joel Stanley wrote: On Thu, 27 Sep 2018 at 01:58, Jae Hyun Yoo wrote: +/* Timeout */ +#define ASPEED_I2C_BUS_TIMEOUT_US_DEFAULT (5 * 1000 * 1000) The 5 seconds time out is way too long. On a system that doesn't have functional i2c, this holds up

Re: [PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed,timeout' DT property reading code

2018-09-27 Thread Jae Hyun Yoo
Hi Joel, On 9/26/2018 8:11 PM, Joel Stanley wrote: On Thu, 27 Sep 2018 at 01:58, Jae Hyun Yoo wrote: +/* Timeout */ +#define ASPEED_I2C_BUS_TIMEOUT_US_DEFAULT (5 * 1000 * 1000) The 5 seconds time out is way too long. On a system that doesn't have functional i2c, this holds up

Re: [PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed,timeout' DT property reading code

2018-09-26 Thread Joel Stanley
On Thu, 27 Sep 2018 at 01:58, Jae Hyun Yoo wrote: > > This commit adds reading code of the 'aspeed,timeout' DT property > to set 'timeout' value in adapter configuration. This value still > case be configured through an I2C_TIMEOUT ioctl on cdev too. > > Signed-off-by: Jae Hyun Yoo > --- >

Re: [PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed,timeout' DT property reading code

2018-09-26 Thread Joel Stanley
On Thu, 27 Sep 2018 at 01:58, Jae Hyun Yoo wrote: > > This commit adds reading code of the 'aspeed,timeout' DT property > to set 'timeout' value in adapter configuration. This value still > case be configured through an I2C_TIMEOUT ioctl on cdev too. > > Signed-off-by: Jae Hyun Yoo > --- >

[PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed,timeout' DT property reading code

2018-09-26 Thread Jae Hyun Yoo
This commit adds reading code of the 'aspeed,timeout' DT property to set 'timeout' value in adapter configuration. This value still case be configured through an I2C_TIMEOUT ioctl on cdev too. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/busses/i2c-aspeed.c | 11 ++- 1 file changed, 10

[PATCH i2c-next v3 2/3] i2c: aspeed: Add 'aspeed,timeout' DT property reading code

2018-09-26 Thread Jae Hyun Yoo
This commit adds reading code of the 'aspeed,timeout' DT property to set 'timeout' value in adapter configuration. This value still case be configured through an I2C_TIMEOUT ioctl on cdev too. Signed-off-by: Jae Hyun Yoo --- drivers/i2c/busses/i2c-aspeed.c | 11 ++- 1 file changed, 10